Skip to content

CSS: Add padding to labels in media filter container#11927

Open
Infinite-Null wants to merge 5 commits into
WordPress:trunkfrom
Infinite-Null:fix/media-modal-filter-label-spacing
Open

CSS: Add padding to labels in media filter container#11927
Infinite-Null wants to merge 5 commits into
WordPress:trunkfrom
Infinite-Null:fix/media-modal-filter-label-spacing

Conversation

@Infinite-Null

@Infinite-Null Infinite-Null commented May 21, 2026

Copy link
Copy Markdown

https://core.trac.wordpress.org/ticket/65300

What

Added a 6px top margin to align with the media modal and maintain visual consistency.

Screenshot 2026-05-22 at 10 26 10 PM Screenshot 2026-05-22 at 10 26 46 PM

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Infinite-Null Infinite-Null marked this pull request as ready for review May 22, 2026 17:00
@github-actions

github-actions Bot commented May 22, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ankitkumarshah, wildworks, masteradhoc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano

t-hamano commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR. However, the attached screenshot does not match my local trunk branch.

First, the media library itself lacks visual labels in the first place:

Screenshot 0008-06-07 at 20 48 10

Furthermore, the .media-frame.mode-grid .media-toolbar selector should not apply to the media library launched in the block editor.

Could you test again if this PR is correct?

@masteradhoc

Copy link
Copy Markdown

@Infinite-Null Thank you very much for the PR. i can confirm the findings of @t-hamano.

The media library looks fine without this PR:
image

With this PR it looks misaligned:
image

--

As we'll the author reported the labels to be too close together - specifically at the select or upload media screen (right @deeppatel8950?)
image

This hasnt been fixed yet. Can you take a look at this?
If you dont have time currently no worries! Feel free to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants