filter page list overlay styles through safecss_filter_attr#12293
filter page list overlay styles through safecss_filter_attr#12293nvxbug wants to merge 1 commit into
Conversation
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @nvxbug. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
Repro: add a Navigation block with a Page List inside it and give the Navigation a custom overlay color carrying extra declarations, e.g. set
customOverlayBackgroundColortored;behavior:url(#default#time2);background:url(javascript:alert(1)). The submenu<li>renders that whole string verbatim in itsstyleattribute for every front-end visitor.Cause:
block_core_page_list_render_nested_page_list()emits the overlay style withesc_attr()alone. The overlay colors arrive as plain Navigation context strings, so they never pass through the style engine,get_block_wrapper_attributes(), or KSES, and the CSS property allowlist is skipped.Fix: wrap the value in
safecss_filter_attr()beforeesc_attr(), matching how the Navigation block renders these same overlay colors.Trac ticket: none yet; happy to open one to track this.
Use of AI Tools