Administration: Skip loading assets for hidden dashboard widgets - #12831
Draft
sanketio wants to merge 1 commit into
Draft
Administration: Skip loading assets for hidden dashboard widgets#12831sanketio wants to merge 1 commit into
sanketio wants to merge 1 commit into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/55344
Summary
Dashboard widgets hidden via Screen Options still enqueue their scripts and
styles, wasting resources on every dashboard load. This adds an optional
$enqueue_callbackparameter towp_add_dashboard_widget()so a widget'sassets are only enqueued when the widget is actually visible.
This is a proof-of-concept for Approach A proposed on the ticket (comment #13).
What changed
wp_add_dashboard_widget()gains an optional 8th parameter,$enqueue_callback(defaultnull, fully backward-compatible).get_hidden_meta_boxes()once and only runs thecallback when the widget is not hidden.
Backward compatibility
null→ existing 7-argument callers are untouched.load — the same trade-off as every other meta-box screen, accepted in comment Remove post_ID requirement from parse_embed AJAX call #7.
Usage
How to test
$enqueue_callbackto enqueue a script.Tests
Adds five PHPUnit tests in
tests/phpunit/tests/admin/includesTemplate.phpcovering visible, hidden, collapsed-not-hidden, null-callback (BC), and
first-visit cases. All pass; PHPCS and PHPStan clean.