I18N: Remove the redundant default text domain from translation function calls. - #12841
I18N: Remove the redundant default text domain from translation function calls.#12841Soean wants to merge 1 commit into
default text domain from translation function calls.#12841Conversation
…ction calls. The `$domain` parameter of `__()` and friends already defaults to `default`, so passing it explicitly in core files is redundant. Core convention is to omit it entirely.
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
It was introduce in https://core.trac.wordpress.org/changeset/60529 / Core-63375
2 participants
The
$domainparameter of__(),_e(),_x()and the other translation functions already defaults todefault. Passing'default'explicitly in core files is redundant, and core convention is to omit the argument entirely.Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.