Create About Page for 7.1 - #12845
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
rbcorrales
left a comment
rbcorrales
left a comment
There was a problem hiding this comment.
Tested locally at different breakpoints plus an he_IL RTL pass. All five pages render clean, no PHP notices, and the RTL headers resolve correctly.
Comments are mostly copy. The one worth catching before RC1 is the run-on on 141, since it's user visible. The rest is minor.
| </div> | ||
| <h3><?php _e( 'Performance' ); ?></h3> | ||
| <p><?php _e( 'WordPress 7.0 improves the accuracy of image loading prioritization, preventing hidden images in navigation overlays or interactive blocks from degrading the loading of critical resources. On-demand block stylesheet loading in classic themes is more reliable, and the ability is added for scripts to depend on script modules to reduce render-blocking.' ); ?></p> | ||
| <h3><?php _e( 'Improved Media Handling' ); ?></h3> |
There was a problem hiding this comment.
This is the only heading that is in title case on the page. The others are in sentence case.
| <h3><?php _e( 'Improved Media Handling' ); ?></h3> | |
| <h3><?php _e( 'Improved media handling' ); ?></h3> |
There was a problem hiding this comment.
I think this is probably a good change; but I'm going to leave it to @marko-srb and @annezazu to make that call.
| <strong><?php _e( 'A centralized hub for your connections.' ); ?></strong><br /> | ||
| <?php _e( 'The Connectors screen introduces a single hub for managing a range of external service integrations, including AI providers. Opt in by connecting your preferred AI provider, then put it to work across your site. The optional AI plugin adds a growing set of tools directly into the editor: create titles and excerpts, generate and edit images, and suggest alt text. Any plugin that needs to connect to an outside service can tap into this standardized connection management system, making it easy for users and developers alike.' ); ?> | ||
| <strong><?php _e( 'Consistent navigation, from dashboard to editor.' ); ?></strong><br /> | ||
| <?php _e( 'The WordPress admin bar now stays with you as you move into the Site Editor and block editor, so you stay oriented as you move between the Site Editor and block editor. Admin bar also receives a small UI visual improvement.' ); ?> |
There was a problem hiding this comment.
the Site Editor and block editor appears twice in the same sentence, and so does as you move.
| <?php _e( 'The WordPress admin bar now stays with you as you move into the Site Editor and block editor, so you stay oriented as you move between the Site Editor and block editor. Admin bar also receives a small UI visual improvement.' ); ?> | |
| <?php _e( 'The WordPress admin bar now travels with you into the Site Editor and the block editor, so you stay oriented as you move between them. The admin bar also receives a small UI visual improvement.' ); ?> |
There was a problem hiding this comment.
@annezazu This is a good suggestion for text revision; leaving it up to you.
| list( $display_version ) = explode( '-', get_bloginfo( 'version' ) ); | ||
| $header_alt_text = sprintf( | ||
| /* translators: %s: Version number. */ | ||
| __( 'WordPress %s' ), | ||
| $display_version | ||
| ); |
There was a problem hiding this comment.
Removing the header image leaves $header_alt_text unused, and $display_version only feeds it, so both are dead now. Same in credits.php, freedoms.php and privacy.php.
There was a problem hiding this comment.
I'm going to leave it for now; but thanks for noting it. If these images stay removed, I'll polish this and remove the dead code paths.
There was a problem hiding this comment.
Quote characters are inconsistent: ’ in the nav, a literal curly ’ on 141, straight ASCII on 66, 125 and 150. Core uses entities for user-facing admin strings (137 ’ against 5 literal curly across src/wp-admin and src/wp-includes).
| line | now | suggested |
|---|---|---|
| 66 | you're |
you’re |
| 125 | Type "@" |
Type “@” |
| 141 | won’t |
won’t |
| 150 | a "mark as decorative" toggle |
a “mark as decorative” toggle |
66 is double-quoted PHP only because of the ', so it can go back to single quotes with the entity.
There was a problem hiding this comment.
These all make sense. All the text was just copied and pasted, but this is more consistent with other strings.
|
One more thing, on narrow screens the header gets shorter, so the background image crops in and "WordPress 7.1" ends up sitting on the green part of the artwork instead of the blue. White on that green is 2.4:1, and it needs at least 3:1 for text that size. Checked at a 430px width. Desktop is fine as the title stays on the blue there. Since the color comes from the image, it needs a different crop or a mobile version rather than a CSS change. Probably a separate ticket though. 
|
|
No, there's no need for a separate ticket; this ticket covers the entire scope of building out the About Page, because it's a one-off task for the release. |
|
@marko-srb Can you take a look at the color contrast concerns on mobile? We could use something like a text shadow on mobile only that addressed this, e.g. ( |
2 participants
Initial draft of the About Page for WordPress 7.1
This draft adds the feature images locally, as the CDN copies are not yet available.
Trac ticket: https://core.trac.wordpress.org/ticket/65698
Use of AI Tools
None
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.