Plugin Directory: Strengthen duplicate-submission prevention on upload#733
Closed
obenland wants to merge 1 commit into
Closed
Plugin Directory: Strengthen duplicate-submission prevention on upload#733obenland wants to merge 1 commit into
obenland wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
obenland
force-pushed
the
plugin-directory/upload-duplicate-check
branch
7 times, most recently
from
July 23, 2026 17:08
303ce1d to
6452114
Compare
Add a short-lived per-slug guard around the final duplicate check and post creation, so that simultaneous submissions of the same new plugin don't each create a separate entry in the review queue. Complements the existing per-user upload lock.
obenland
force-pushed
the
plugin-directory/upload-duplicate-check
branch
from
July 23, 2026 18:03
6452114 to
f9852f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the duplicate-submission hardening in #698.
The per-user upload lock keeps a single submitter from creating duplicates via double-clicks or reloads, but the final duplicate check and post creation aren't otherwise coordinated, so two submissions of the same new plugin can each pass the earlier checks and land as separate queue entries.
This adds a short-lived, per-slug guard (
wp_cache_add, same primitive as the existing lock) around the final check-and-create step: the slug is claimed for the moment it takes to re-check for an existing plugin and create the post, then released. If the slug is already claimed, or a matching plugin now exists, the submission is rejected with a transient "currently being processed, please try again in a moment" notice — on retry, the regular duplicate checks then produce the appropriate permanent error.Scope:
Result: fewer duplicate entries in the review queue and less manual triage for the plugins team.
🤖 Generated with Claude Code