2.7.1 updates#82
Merged
mambax7 merged 2 commits intoMay 30, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAligns block clone validation with a renamed language constant, ensures Debugbar logger loads language strings before processing Smarty data, and updates the core version to 2.7.1-Beta1. Sequence diagram for DebugbarLogger addSmarty language loadingsequenceDiagram
actor Admin
participant DebugbarLogger
participant Helper
Admin->>DebugbarLogger: addSmarty()
DebugbarLogger->>Helper: getInstance()
Helper-->>DebugbarLogger: helper
DebugbarLogger->>Helper: loadLanguage(main)
DebugbarLogger->>DebugbarLogger: [normalize data for display]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR prepares the 2.7.1-Beta1 release by bumping the kernel version constant, standardizing block admin language constant naming with an underscore prefix, synchronizing test bootstrap and assertions to track the shipped version, initializing language context in Debugbar, and documenting changelog entries. ChangesRelease 2.7.1-Beta1 Preparation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Renaming
_AM_SYSTEM_BLOCKS_INVALIDCLONEto_AM_SYSTEM_BLOCKS_INVALID_CLONEonly in the English language file and a few call sites may leave other locales or modules still using the old key; consider grepping for the old constant name across the project and updating all remaining references for consistency. Helper::getInstance()->loadLanguage('main')inDebugbarLogger::addSmarty()will now run on every call; if this method is invoked frequently, consider caching the fact that the language has been loaded (or moving the call to a one-time initialization path) to avoid repeated work.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Renaming `_AM_SYSTEM_BLOCKS_INVALIDCLONE` to `_AM_SYSTEM_BLOCKS_INVALID_CLONE` only in the English language file and a few call sites may leave other locales or modules still using the old key; consider grepping for the old constant name across the project and updating all remaining references for consistency.
- `Helper::getInstance()->loadLanguage('main')` in `DebugbarLogger::addSmarty()` will now run on every call; if this method is invoked frequently, consider caching the fact that the language has been loaded (or moving the call to a one-time initialization path) to avoid repeated work.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #82 +/- ##
============================================
+ Coverage 18.13% 18.19% +0.05%
- Complexity 7854 7861 +7
============================================
Files 666 667 +1
Lines 43208 43259 +51
============================================
+ Hits 7837 7872 +35
- Misses 35371 35387 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the XOOPS version to 2.7.1-Beta1, renames the language constant _AM_SYSTEM_BLOCKS_INVALIDCLONE to _AM_SYSTEM_BLOCKS_INVALID_CLONE across the codebase and documentation, and ensures the 'main' language file is loaded in the DebugbarLogger. There are no review comments, so I have no feedback to provide.
Contributor
There was a problem hiding this comment.
Pull request overview
Small maintenance PR preparing the 2.7.1-Beta1 release: bumps the core version string, fixes a constant-name mismatch between the blocksadmin language file and its three clone-validation redirects, and ensures Debugbar's logger loads its language file before consuming _MD_DEBUGBAR_* constants in addSmarty(). Also updates the language-diff doc to record the renamed constant under a new 2.7.1-Betas section.
Changes:
- Rename
_AM_SYSTEM_BLOCKS_INVALIDCLONE→_AM_SYSTEM_BLOCKS_INVALID_CLONEin the language file and update the threeredirect_header()call sites in blocksadmin clone validation. - Load the Debugbar
mainlanguage file at the top ofDebugbarLogger::addSmarty()so the display constants are guaranteed to be defined. - Bump
XOOPS_VERSIONtoXOOPS 2.7.1-Beta1and document the language-string move indocs/lang_diff.txt.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| htdocs/modules/system/language/english/admin/blocksadmin.php | Renames constant to _AM_SYSTEM_BLOCKS_INVALID_CLONE. |
| htdocs/modules/system/admin/blocksadmin/main.php | Updates the three clone-validation redirects to the renamed constant. |
| htdocs/modules/debugbar/class/DebugbarLogger.php | Loads debugbar main language file before normalizing Smarty values. |
| htdocs/include/version.php | Bumps XOOPS_VERSION to XOOPS 2.7.1-Beta1. |
| docs/lang_diff.txt | Adds 2.7.1-Betas section documenting the renamed language constant. |
| * Define XOOPS version | ||
| */ | ||
| define('XOOPS_VERSION', 'XOOPS 2.7.0'); | ||
| define('XOOPS_VERSION', 'XOOPS 2.7.1-Beta1'); |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/lang_diff.txt`:
- Line 7: Update the release label string in the changelog entry currently
reading "Version 2.7.1-Betas" to match the shipped version "Version
2.7.1-Beta1"; locate the text "Version 2.7.1-Betas" in docs/lang_diff.txt and
replace it with "Version 2.7.1-Beta1" to ensure the release label matches the
actual release tag.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: f999fccd-105e-4ac9-9d8b-938ee512a5a4
📒 Files selected for processing (8)
.gitignoredocs/lang_diff.txthtdocs/include/version.phphtdocs/modules/debugbar/class/DebugbarLogger.phphtdocs/modules/system/admin/blocksadmin/main.phphtdocs/modules/system/language/english/admin/blocksadmin.phptests/bootstrap.phptests/unit/htdocs/include/VersionTest.php
| Below are language differences from a version to next version. | ||
|
|
||
| ================================ | ||
| 2026/05/17: Version 2.7.1-Betas |
There was a problem hiding this comment.
Align release label with the shipped version string.
Version 2.7.1-Betas is inconsistent with the actual release target (2.7.1-Beta1), which can cause changelog ambiguity.
Suggested doc fix
-2026/05/17: Version 2.7.1-Betas
+2026/05/17: Version 2.7.1-Beta1📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| 2026/05/17: Version 2.7.1-Betas | |
| 2026/05/17: Version 2.7.1-Beta1 |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/lang_diff.txt` at line 7, Update the release label string in the
changelog entry currently reading "Version 2.7.1-Betas" to match the shipped
version "Version 2.7.1-Beta1"; locate the text "Version 2.7.1-Betas" in
docs/lang_diff.txt and replace it with "Version 2.7.1-Beta1" to ensure the
release label matches the actual release tag.
…rs the real value bootstrap.php hardcoded 'XOOPS 2.7.0-RC1', shadowing version.php's unconditional define(). VersionTest therefore validated the stale fixture instead of the file, leaving the 2.7.1-Beta1 bump untested (0% patch coverage on version.php). Load the real version.php in the bootstrap and relax the exact-version assertion to the 2.7. line so future patch and pre-release bumps within the line don't churn the test. Two optional follow-ups still open from the review, neither blocking: - docs/lang_diff.txt could record the constant change as a rename rather than a delete-from-2.7.0 + add-to-2.7.1 (cosmetic, since no 2.7.0 stable shipped). - The Debugbar 3 lines remain uncoverable by Codecov because htdocs/modules/debugbar isn't in the <source> include in tests/phpunit.xml.dist — expected, not something this PR needs to fix.
mambax7
force-pushed
the
feature/start_version_update_2.7.1
branch
from
7ebca3b to
f8838e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update language constants and version metadata for the 2.7.1 beta release.
Bug Fixes:
Enhancements:
Summary by CodeRabbit
New Features
Bug Fixes
Tests