fix bug for : AS5600.zig,MPU_6050.zig #974
Closed
by965738071 wants to merge 5 commits into
Closed
Conversation
- riscv32: fix wfe() using wrong CSR address 0x810 -> 0x300 (mstatus) - msp430: fix memset/memcpy assembly operand order (TI syntax: OP src, dst) - cortex_m: add missing return in set_pending/clear_pending for m0+ - cortex_m/m0plus: fix NVIC is_enabled/is_pending return type void -> bool - utilities: fix CircularBuffer write/read hardcoded to u8 instead of T
mattnite
requested changes
Jul 14, 2026
mattnite
left a comment
Contributor
There was a problem hiding this comment.
Hey I really appreciate all these fixes, but a lot of them are unrelated to one another and we use squash merges in this repo for. Please create separate PRs for each fix.
mattnite
requested changes
Jul 14, 2026
| => { | ||
| if (excpt == .SVCALL) ppb.SHCSR.raw |= 0x0000_8000; | ||
| @compileError("not supported on this platform"); | ||
| if (excpt == .SVCALL) ppb.SHCSR.raw |= 0x0000_8000 orelse |
This reverts commit 117a4f1.
Author
|
closed all pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix:1:as5600,use
try read2_raw function.2:mpu6050 read_reg timeout.