Skip to content

fix bug for : AS5600.zig,MPU_6050.zig #974

Closed
by965738071 wants to merge 5 commits into
ZigEmbeddedGroup:mainfrom
by965738071:main
Closed

fix bug for : AS5600.zig,MPU_6050.zig #974
by965738071 wants to merge 5 commits into
ZigEmbeddedGroup:mainfrom
by965738071:main

Conversation

@by965738071

Copy link
Copy Markdown

fix:1:as5600,use try read2_raw function.2:mpu6050 read_reg timeout.

- riscv32: fix wfe() using wrong CSR address 0x810 -> 0x300 (mstatus)
- msp430: fix memset/memcpy assembly operand order (TI syntax: OP src, dst)
- cortex_m: add missing return in set_pending/clear_pending for m0+
- cortex_m/m0plus: fix NVIC is_enabled/is_pending return type void -> bool
- utilities: fix CircularBuffer write/read hardcoded to u8 instead of T

@mattnite mattnite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I really appreciate all these fixes, but a lot of them are unrelated to one another and we use squash merges in this repo for. Please create separate PRs for each fix.

Comment thread core/src/cpus/cortex_m.zig Outdated
=> {
if (excpt == .SVCALL) ppb.SHCSR.raw |= 0x0000_8000;
@compileError("not supported on this platform");
if (excpt == .SVCALL) ppb.SHCSR.raw |= 0x0000_8000 orelse

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't compile.

@by965738071

Copy link
Copy Markdown
Author

closed all pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants