Skip to content

feat(chat): enable jump-to-file in regular chat diff accordions (#997) #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrawenCZ wants to merge 1 commit into
base: main
Choose a base branch
from
+28 −3
Open

feat(chat): enable jump-to-file in regular chat diff accordions (#997) #1011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions webview-ui/src/components/chat/ChatRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,8 +420,8 @@ export const ChatRowContent = ({
return (tool.content ?? tool.diff) as string | undefined
}, [tool])

const onJumpToCreatedFile = useMemo(() => {
if (!tool || tool.tool !== "newFileCreated" || !tool.path) {
const onJumpToFile = useMemo(() => {
if (!tool || !tool.path) {
return undefined
}

Expand Down Expand Up @@ -497,7 +497,7 @@ export const ChatRowContent = ({
isLoading={message.partial}
isExpanded={isExpanded}
onToggleExpand={handleToggleExpand}
onJumpToFile={onJumpToCreatedFile}
onJumpToFile={onJumpToFile}
diffStats={tool.diffStats}
/>
</div>
Expand Down Expand Up @@ -536,6 +536,7 @@ export const ChatRowContent = ({
isLoading={message.partial}
isExpanded={isExpanded}
onToggleExpand={handleToggleExpand}
onJumpToFile={onJumpToFile}
diffStats={tool.diffStats}
/>
</div>
Expand Down
24 changes: 24 additions & 0 deletions webview-ui/src/components/chat/__tests__/ChatRow.diff-actions.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,30 @@ describe("ChatRow - inline diff stats and actions", () => {
})
})

it("shows jump-to-file affordance for appliedDiff", () => {
const message = createToolAskMessage({
tool: "appliedDiff",
path: "src/file.ts",
diff: "@@ -1,1 +1,1 @@\n-old\n+new\n",
diffStats: { added: 1, removed: 1 },
})

const { container } = renderChatRow(message)
const openFileIcon = container.querySelector(".codicon-link-external") as HTMLElement | null

expect(openFileIcon).toBeInTheDocument()
if (!openFileIcon) {
throw new Error("Expected external link icon for appliedDiff")
}

fireEvent.click(openFileIcon)

expect(mockPostMessage).toHaveBeenCalledWith({
type: "openFile",
text: "./src/file.ts",
})
})

it("preserves protected and outside-workspace messaging in unified branch", () => {
const outsideWorkspaceMessage = createToolAskMessage({
tool: "searchAndReplace",
Expand Down
Loading