feat(friendli): fetch model list dynamically from /v1/models#1027
Closed
Lee-Si-Yoon wants to merge 2 commits into
Closed
feat(friendli): fetch model list dynamically from /v1/models#1027Lee-Si-Yoon wants to merge 2 commits into
Lee-Si-Yoon wants to merge 2 commits into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Convert Friendli from a static provider (4 hardcoded models) to a dynamic provider that fetches the live model list from the public https://api.friendli.ai/serverless/v1/models endpoint at runtime. - Add getFriendliModels() fetcher with zod schema validation - Wire friendli into modelCache, webviewMessageHandler, and dynamicProviders - FriendliHandler loads dynamic models in constructor, falls back to static friendliModels for cold-start and API lag - UI model picker uses routerModels.friendli instead of static list - Add fetcher spec (14 tests) and update Friendli.spec.tsx with ModelPicker mock
Lee-Si-Yoon
force-pushed
the
feat/friendli-dynamic-models
branch
from
July 26, 2026 12:14
889b49e to
bab25e8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #886. Merge #886 first, then this PR rebases cleanly.
Friendli's model list is now fetched live from
GET /v1/modelsinstead of being hardcoded to four entries. The endpoint is public (no auth header needed), same as Vercel AI Gateway and OpenRouter in this repo.fetchers/friendli.ts): zod-validated axios call mapping API fields toModelInfo— pricing, cache read/write, reasoning effort options, image modality, deprecation.FriendliHandlerfire-and-forgets a model fetch in the constructor.getModel()prefers dynamic data, falls back to staticfriendliModelsduring cold start or API lag."friendli"moved todynamicProviders.ModelPickerfed byrouterModels.friendli, replacing the hardcoded dropdown.