Conversation
Signed-off-by: Derek Wang <whynowy@gmail.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the accuracy and usability of the project's documentation by resolving broken links within the main README file. The changes ensure that users can correctly access the contributing guide and the community discussion forum, enhancing the overall user experience and maintainability of the project's entry point. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request fixes a few broken links in the organization's profile README. The changes correctly update the discussions link and the path to the contributing guide. I've added one suggestion to use an absolute URL for the contributing guide to make it more robust. Also, there's a small typo in the pull request title ('deak' should be 'dead').
| ## Contributing | ||
|
|
||
| We welcome contributions of all kinds! Whether you want to fix bugs, improve documentation, or propose new protocol extensions, please see our [contributing guide](CONTRIBUTING.md) to get started. | ||
| We welcome contributions of all kinds! Whether you want to fix bugs, improve documentation, or propose new protocol extensions, please see our [contributing guide](../CONTRIBUTING.md) to get started. |
There was a problem hiding this comment.
For better link robustness and clarity, it's recommended to use an absolute URL for the contributing guide instead of a relative one. Relative links can be fragile if the file structure changes or if the content is viewed outside of its intended GitHub context. Using an absolute URL ensures the link will always point to the correct location.
| We welcome contributions of all kinds! Whether you want to fix bugs, improve documentation, or propose new protocol extensions, please see our [contributing guide](../CONTRIBUTING.md) to get started. | |
| We welcome contributions of all kinds! Whether you want to fix bugs, improve documentation, or propose new protocol extensions, please see our [contributing guide](https://github.com/a2aproject/.github/blob/main/CONTRIBUTING.md) to get started. |
There was a problem hiding this comment.
Code Review
This pull request fixes a couple of dead links in the organization's profile README. The changes correctly update the discussion links. However, the fix for the 'contributing guide' link might not be robust. I've added a suggestion to use an absolute URL to ensure it works correctly. Also, there's a small typo in the pull request title ('deak' should be 'dead').
| ## Contributing | ||
|
|
||
| We welcome contributions of all kinds! Whether you want to fix bugs, improve documentation, or propose new protocol extensions, please see our [contributing guide](CONTRIBUTING.md) to get started. | ||
| We welcome contributions of all kinds! Whether you want to fix bugs, improve documentation, or propose new protocol extensions, please see our [contributing guide](../CONTRIBUTING.md) to get started. |
There was a problem hiding this comment.
While ../CONTRIBUTING.md might resolve correctly in some contexts, using an absolute URL would be more robust, especially for a README displayed on an organization's profile page. This ensures the link will always point to the correct file, regardless of how the page is rendered. Other links in this file, like the one to the specification, are also absolute.
| We welcome contributions of all kinds! Whether you want to fix bugs, improve documentation, or propose new protocol extensions, please see our [contributing guide](../CONTRIBUTING.md) to get started. | |
| We welcome contributions of all kinds! Whether you want to fix bugs, improve documentation, or propose new protocol extensions, please see our [contributing guide](https://github.com/a2aproject/A2A/blob/main/CONTRIBUTING.md) to get started. |
Fix some dead links: