feat(admin): Return to the current page after re-signing in - #754
Closed
aXenDeveloper wants to merge 1 commit into
Closed
feat(admin): Return to the current page after re-signing in#754aXenDeveloper wants to merge 1 commit into
aXenDeveloper wants to merge 1 commit into
Conversation
When an admin session expires, the AdminCP now remembers the page the admin was on as a `?redirect=` query on the sign-in URL and sends them back there after signing in, instead of always landing on the dashboard. The Proxy stamps every request with `x-vitnode-pathname` (pathname plus query, locale prefix stripped), since a Server Component only ever sees the rewritten internal URL. `getSessionAdminApi` reads it when the session check fails, and the sign-in form carries the value through to the Server Action. The value is untrusted on both hops, so it is validated twice: only locale-less paths under `/admin` survive, which keeps an absolute or protocol-relative URL, a `..` segment, or the sign-in page itself from turning sign-in into an open redirect or a loop. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SUTFv2hU42T1XJ7wU6vGjx
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an admin session expires, the AdminCP now remembers the page the
admin was on as a
?redirect=query on the sign-in URL and sends themback there after signing in, instead of always landing on the dashboard.
The Proxy stamps every request with
x-vitnode-pathname(pathname plusquery, locale prefix stripped), since a Server Component only ever sees
the rewritten internal URL.
getSessionAdminApireads it when thesession check fails, and the sign-in form carries the value through to
the Server Action.
The value is untrusted on both hops, so it is validated twice: only
locale-less paths under
/adminsurvive, which keeps an absolute orprotocol-relative URL, a
..segment, or the sign-in page itself fromturning sign-in into an open redirect or a loop.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01SUTFv2hU42T1XJ7wU6vGjx