feat: expose progress_callback in Llama wrapper#2340
Open
Niels-BW wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes
progress_callbackandprogress_callback_user_datathrough the high-level Llama constructor.llama_model_paramsalready supports these fields, and the ctype bindings already expose them, but they are not currently available through theLlamaAPI.This allows Python applications to receive model loading progress and optionally abort model loading by returning
Falsefrom the callback, consistent with the underlying llama.cpp API.Implementation
progress_callbackandprogress_callback_user_datato theLlamaconstructorllama_progress_callbackLlamainstance to prevent it from being garbage collected before model loading completes.Testing
This change was tested by successfully receiving model loading progress callbacks and aborting model loading by returning False from the callback.