Fix masked license validation tests - #5258
Open
w3lld1 wants to merge 2 commits into
Open
Conversation
Signed-off-by: w3lld1 <42353747+w3lld1@users.noreply.github.com>
Signed-off-by: w3lld1 <42353747+w3lld1@users.noreply.github.com>
Author
|
Fixed the license-data-sensitive CI failure in Fresh validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I renamed the two colliding license rule files so each generated validation test receives a distinct Python name. I also added a regression test that rejects future rule-file name collisions, and updated the contributor and changelog entries.
Validation
I ran:
PYTHONPATH=src pytest -q tests/licensedcode/test_rule_file_names.pyruff check tests/licensedcode/test_rule_file_names.pyruff format --check tests/licensedcode/test_rule_file_names.pypython -m py_compile tests/licensedcode/test_rule_file_names.pygit diff --check origin/develop...HEADI did not run the full 29,000+ test suite locally; I deferred it to CI because the focused regression and static checks cover the changed path.
Tasks
CHANGELOG.rstAUTHORS.rstFixes #5257