Skip to content

guard invalid _FloatN width in ParseBuiltinType #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nabhan06 wants to merge 1 commit into from
+17 −1
Closed

guard invalid _FloatN width in ParseBuiltinType #2128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion absl/debugging/internal/demangle.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1645,7 +1645,11 @@ static bool ParseBuiltinType(State *state) {
return false;
}
MaybeAppend(state, "_Float");
MaybeAppendDecimal(state, number);
if (number >= 0) {
MaybeAppendDecimal(state, number);
} else {
MaybeAppend(state, "?"); // the best we can do for an invalid width
}
if (ParseOneCharToken(state, 'x')) {
MaybeAppend(state, "x");
return true;
Expand Down
12 changes: 12 additions & 0 deletions absl/debugging/internal/demangle_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,6 +705,18 @@ TEST(Demangle, Float128x) {
EXPECT_STREQ("S::operator _Float128x()", tmp);
}

TEST(Demangle, InvalidFloatNWidth) {
char tmp[80];

// A negative or overflowed _FloatN width is not printable, so render it as
// "?" like the sibling _BitInt path instead of emitting garbage bytes.
EXPECT_TRUE(Demangle("_ZNK1ScvDFn3_Ev", tmp, sizeof(tmp)));
EXPECT_STREQ("S::operator _Float?()", tmp);

EXPECT_TRUE(Demangle("_ZNK1ScvDF2147483648_Ev", tmp, sizeof(tmp)));
EXPECT_STREQ("S::operator _Float?()", tmp);
}

TEST(Demangle, Bfloat16) {
char tmp[80];

Expand Down