Align with Amazon SP-API 2025 deprecations#932
Merged
Conversation
Owner
abuzuhri
commented
Apr 25, 2026
abuzuhri
commented
- Mark Catalog Items v0 calls (ListCatalogItems, ListCatalogCategories, GetCatalogItemJson) as [Obsolete] with messages noting Amazon removed v0 on 2025-03-31; the underlying URLs return 404. Mirror the obsolete on the matching sample.
- Drop the 'name is required' null-check from Orders v0 Address ctor since Amazon's 2025-10 release made Name optional on getOrderAddress.
- README: replace stale GetOrderAddress notice with a heads-up block covering Catalog v0 removal, XML feeds shutoff (2025-07-31), Orders v0 sunset (2027-03-27) and the OrdersV20260101 path, and Address.Name now optional.
- Mark Catalog Items v0 calls (ListCatalogItems, ListCatalogCategories, GetCatalogItemJson) as [Obsolete] with messages noting Amazon removed v0 on 2025-03-31; the underlying URLs return 404. Mirror the obsolete on the matching sample. - Drop the 'name is required' null-check from Orders v0 Address ctor since Amazon's 2025-10 release made Name optional on getOrderAddress. - README: replace stale GetOrderAddress notice with a heads-up block covering Catalog v0 removal, XML feeds shutoff (2025-07-31), Orders v0 sunset (2027-03-27) and the OrdersV20260101 path, and Address.Name now optional. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
There was a problem hiding this comment.
Pull request overview
Updates the library’s public surface and documentation to reflect Amazon SP-API deprecations/removals (Catalog Items v0 removal, Orders v0 changes), helping consumers avoid dead endpoints and outdated assumptions.
Changes:
- Mark Catalog Items API v0 methods as
[Obsolete](and hide from IntelliSense) with updated messages reflecting Amazon’s 2025-03-31 removal. - Make Orders v0
Addressconstructor acceptNameas optional by removing the required-null check. - Refresh README guidance with a consolidated “Heads-up” block about SP-API lifecycle changes; mirror relevant obsoletes in sample code.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Source/FikaAmazonAPI/Services/CatalogItemService.cs | Adds/updates [Obsolete] metadata for Catalog Items v0 methods to reflect endpoint removal and steer users to 2022-04-01 APIs. |
| Source/FikaAmazonAPI/AmazonSpApiSDK/Models/Orders/Address.cs | Removes the constructor’s name required check so Address.Name can be null per Amazon’s newer behavior. |
| Source/FikaAmazonAPI.SampleCode/CatalogItemsSample.cs | Marks v0 sample calls obsolete with updated removal messaging to discourage usage. |
| README.md | Replaces a stale note with a detailed “Heads-up” section describing Amazon-side deprecations and migration pointers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// Initializes a new instance of the <see cref="Address" /> class. | ||
| /// </summary> | ||
| /// <param name="name">The name. (required).</param> | ||
| /// <param name="name">The name..</param> |
There was a problem hiding this comment.
XML doc typo: the name parameter description has a double period (The name..). Update it to a single period and (optionally) clarify that the value is now optional/null-able to match the constructor behavior.
Suggested change
| /// <param name="name">The name..</param> | |
| /// <param name="name">The name. Optional; can be null.</param> |
| > ### Heads-up: Amazon-side changes affecting this library | ||
| > | ||
| > - **Catalog Items API v0 was removed by Amazon on 2025-03-31.** `CatalogItem.ListCatalogItems`, `CatalogItem.ListCatalogCategories`, and `CatalogItem.GetCatalogItemJson` are now marked obsolete because the underlying endpoints no longer exist. Use the 2022-04-01 methods (`SearchCatalogItems202204`, `GetCatalogItem202204`) instead. | ||
| > - **XML feed types (e.g. the legacy inventory feed) were turned off on 2025-07-31.** If you previously submitted inventory updates with `_POST_INVENTORY_AVAILABILITY_DATA_` or similar XML feed types, migrate to `FeedType.JSON_LISTINGS_FEED` with a JSON-Patch payload (see `FeedsSample.cs`). |
There was a problem hiding this comment.
In Markdown, _POST_INVENTORY_AVAILABILITY_DATA_ will render as italic text rather than a literal feed type. Wrap the feed type(s) in backticks so users can copy/paste the exact value and the formatting stays consistent with the other inline code in this block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.