feat(csharp): implement visitMapDeclaration and fix optional map fields#229
Merged
Merged
Conversation
8745314 to
4a0250e
Compare
Signed-off-by: muhammed-abdulkadir <muhammed.abdulkadir@docusign.com>
4a0250e to
db5e86d
Compare
jamieshorten
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
CSharp Visitor — Map Declaration Support
visitMapDeclarationwas silently skipped. Thevisit()dispatch returned early for map declarations with no output. Map types produced nothing in the generated C# file.Each Concerto map declaration now emits a named class extending
Dictionary<K,V>:Optional map fields never emitted ?
writeField's map path had noisOptional()check. A field declared optional likeo CompanyProperties companyProperties optionalalways emitted a non-nullable type. Fixed to emitDictionary<K,V>?when optional.Author Checklist
--signoffoption of git commit.mainfromfork:branchname