[my_preferences] Allow emojis#10900
Open
lapadulamichael wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
Language: SQL
lapadulamichael
added
the
29.0.0 - Bugs
lapadulamichael
changed the title
driusan
reviewed
Jul 14, 2026
| MODIFY userID varchar(255) CHARACTER SET utf8mb4 NOT NULL DEFAULT '', | ||
| MODIFY type char(1) CHARACTER SET utf8mb4 NULL DEFAULT NULL; | ||
|
|
||
| ALTER TABLE users |
Collaborator
There was a problem hiding this comment.
- This default schema needs to be modified as well
- Shouldn't we just modify the charset for the table instead of doing it individually for each column?
driusan
reviewed
Jul 14, 2026
| MODIFY primaryCols text CHARACTER SET utf8mb4 NULL DEFAULT NULL, | ||
| MODIFY primaryVals text CHARACTER SET utf8mb4 NULL DEFAULT NULL, | ||
| MODIFY userID varchar(255) CHARACTER SET utf8mb4 NOT NULL DEFAULT '', | ||
| MODIFY type char(1) CHARACTER SET utf8mb4 NULL DEFAULT NULL; |
Collaborator
There was a problem hiding this comment.
I think this table should have the charset modified on the table level instead of individual columns as well, but if it is done for individual columns this one can never store an emoji anyways.. it's 1 byte and hardcoded in the code
lapadulamichael
force-pushed
the
2026_07_13_Fix_emojis_wont_save_my_preferences
branch
from
9693641 to
9117aec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
In the my_preference module, allow saving First Name, Last Name and/or Email with emojis
utf8mb4when creating the PDO for db connectionusersandhistorytable toutf8mb4Testing instructions (if applicable)
my_preferencesLink(s) to related issue(s)