Skip to content

Feat/ttlfixes#122

Merged
Youmanvi merged 4 commits into
mainfrom
feat/ttlfixes
Mar 30, 2026
Merged

Feat/ttlfixes#122
Youmanvi merged 4 commits into
mainfrom
feat/ttlfixes

Conversation

@Youmanvi
Copy link
Copy Markdown
Contributor

@Youmanvi Youmanvi commented Mar 16, 2026

  • Exit deletes room: Added missing /leave route in the Node.js proxy; backend now deletes the
    room when the creator leaves or the room becomes empty, cancels the TTL scheduler, and
    clears all Redis state (join timestamps + user active-room pointers)
  • Multi-round support: StartRoundByRoomID searches for a CREATED round by status instead of
    taking Rounds[last] (non-deterministic GORM order); CheckRoundLimitExceeded now counts only
    non-ENDED rounds so completed rounds don't block new ones; EndRoundByRoomID finds
    the actively STARTED round explicitly
  • Round start resilience: handleStartRound now uses a try-start → create-if-404 → retry-start
    pattern instead of a roundReady frontend state flag, making it robust against popup reopens
    and WS delivery delays; if create fails with "round limit exceeded" it fetches room state and
    syncs roundStarted directly
  • Room-level timer: Timer countdown begins at room creation (not round start) and is never
    reset by round events; round-start WS handler no longer recalculates endTime; checkActiveRoom
    restores timer from room.expiresAt
  • FK cascade on round deletion: Added OnDelete:CASCADE to round_problems join table;
    deleteRoom explicitly removes submissions, participants, and join-table rows to avoid FK
    violations
  • Error messages: Frontend now checks data.message (Echo's format) in addition to data.error
    so the actual backend message is shown
  • clearMessages on round end: Chat history is cleared when a round ends so a new round starts
    with a fresh chat

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bsg Ready Ready Preview, Comment Mar 30, 2026 11:44pm

Request Review

Copy link
Copy Markdown
Contributor

@Eskan0r Eskan0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait till calvin merges his pr and then pull and check for merge conflicts and then merge yours. ik u pr'd first but ik ur goated with the merge conflicts 😎

Copy link
Copy Markdown
Contributor

@Owen-Isenhart Owen-Isenhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm simple enough

@Youmanvi Youmanvi merged commit 7906a2a into main Mar 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants