Feat/ttlfixes#122
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owen-Isenhart
approved these changes
Mar 30, 2026
Contributor
Owen-Isenhart
left a comment
There was a problem hiding this comment.
lgtm simple enough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
room when the creator leaves or the room becomes empty, cancels the TTL scheduler, and
clears all Redis state (join timestamps + user active-room pointers)
taking Rounds[last] (non-deterministic GORM order); CheckRoundLimitExceeded now counts only
non-ENDED rounds so completed rounds don't block new ones; EndRoundByRoomID finds
the actively STARTED round explicitly
pattern instead of a roundReady frontend state flag, making it robust against popup reopens
and WS delivery delays; if create fails with "round limit exceeded" it fetches room state and
syncs roundStarted directly
reset by round events; round-start WS handler no longer recalculates endTime; checkActiveRoom
restores timer from room.expiresAt
deleteRoom explicitly removes submissions, participants, and join-table rows to avoid FK
violations
so the actual backend message is shown
with a fresh chat