Skip to content

Feat/prob tags#133

Merged
git-yash merged 12 commits into
mainfrom
feat/prob_tags
Apr 17, 2026
Merged

Feat/prob tags#133
git-yash merged 12 commits into
mainfrom
feat/prob_tags

Conversation

@Owen-Isenhart
Copy link
Copy Markdown
Contributor

@Owen-Isenhart Owen-Isenhart commented Apr 4, 2026

looks bigger than it is cuz a 4k line csv is being replaced

adds actual problem tag functionality, so selecting them actually does something. also makes them not hardcoded on the frontend. also tried removing a lot of the alerts when we get errors on the frontend cuz alerts are hideous. also has import fixes on the frontend cuz i wasn't able to run it. might be other stuff but pretty chill

2026-04-04.17-25-22.mp4

there's fallback logic for if they select a tag but the difficulty they want for that tag isn't available, it'll just give them the problem anyways even if it's the wrong difficulty and show them a message for that. if there's deadass not enough problems for what they select, they'll be shown it before they can create the room. the logic for the tags is ORs not ANDs, meaning if you select hash table and greedy, it can give you a problem with only hash table, only greedy, or both. that way we run into issues less

2026-04-04.17-52-14.mp4

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bsg Ready Ready Preview, Comment Apr 16, 2026 1:06am

Request Review

@Owen-Isenhart Owen-Isenhart marked this pull request as ready for review April 4, 2026 22:57
Copy link
Copy Markdown
Contributor

@Eskan0r Eskan0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the merge conflicts it looks pretty chill other than maybe a race condition in useChatSocket.ts where the joinedRoomIDRef is set after sending the message, but there might be a timing issue where reconnects could trigger duplicate join messages, the check if (joinedRoomIDRef.current === roomID) { return; } happens after setting pending room meaning it could miss duplicate prevention

@Eskan0r Eskan0r requested a review from git-yash April 13, 2026 20:41
Copy link
Copy Markdown
Collaborator

@git-yash git-yash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this error on Chrome extension: ResizeObserver loop completed with undelivered notifications.

API fetching in the frontend could use some refactoring, but not an urgent issue.

Everything else looks great

@Owen-Isenhart
Copy link
Copy Markdown
Contributor Author

fixed merge issue (it was a package lock thing, i just pushed the package-lock i had since it should be most up to date but if there's issues after merged it can be fixed), made the change for the potential race condition which prob isn't really an issue but did anyways, and i can't reproduce yash's error but asked ai why it might be happening and it did some shit that might fix idk

@Owen-Isenhart Owen-Isenhart requested a review from git-yash April 14, 2026 01:26
@Owen-Isenhart
Copy link
Copy Markdown
Contributor Author

if this doesn't get approved in the next two weeks im closing the PR and you'll never see this code again

@git-yash git-yash merged commit d15f239 into main Apr 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants