CLI-1860: Updated response to include download links. - #2028
Draft
vishalkhode1 wants to merge 2 commits into
Draft
CLI-1860: Updated response to include download links.#2028vishalkhode1 wants to merge 2 commits into
vishalkhode1 wants to merge 2 commits into
Conversation
|
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/2028/acli.phar |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2028 +/- ##
=========================================
Coverage 92.49% 92.50%
- Complexity 1995 2000 +5
=========================================
Files 123 123
Lines 7238 7246 +8
=========================================
+ Hits 6695 6703 +8
Misses 543 543 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
deepakmishra2
changed the title
deepakmishra2
requested changes
Jul 24, 2026
deepakmishra2
left a comment
deepakmishra2
left a comment
Contributor
There was a problem hiding this comment.
We should also add test for api:site-instances:database:backups with a _links.download fixture and asserts the download URL is preserved.
| $this->assertArrayNotHasKey('_links', $decoded[0]); | ||
| $this->assertArrayNotHasKey('_links', $decoded[1]); | ||
| $this->assertArrayHasKey('_links', $decoded[0]); | ||
| $this->assertEmpty($decoded[0]['_links']); |
Contributor
There was a problem hiding this comment.
and once we have the test we can change this assertion to assertArrayNotHasKey('_links', ...) for fixtures without a download key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.