Fix helm chart validation workflow#4479
Conversation
nikola-jokic
requested review from
a team,
Steve-Glass,
mumoshu,
rentziass and
toast-gear
as code owners
|
Hello! Thank you for your contribution. Please review our contribution guidelines to understand the project's testing and code conventions. |
There was a problem hiding this comment.
Pull request overview
Updates the GHA Helm chart validation pipeline to lint/test the intended set of charts (including experimental ones) and adjusts the testing approach used in CI.
Changes:
- Add experimental charts to the chart-testing (
ct) config so they’re included in linting. - Populate the
validate-chartjob with checkout/helm/python/ct steps and runct lint. - Remove Go-based template tests for experimental charts and run helm-unittest for experimental charts in CI.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| charts/gha-runner-scale-set-experimental/tests/template_test.go | Removes Go-based template test for experimental scale-set chart. |
| charts/gha-runner-scale-set-controller-experimental/tests/template_test.go | Removes Go-based template test for experimental controller chart. |
| charts/.ci/ct-config-gha.yaml | Expands ct chart list to include experimental charts. |
| .github/workflows/gha-validate-chart.yaml | Reworks validation workflow: adds dedicated lint job steps and runs helm-unittest for experimental charts; removes some prior CI steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Run chart-testing (list-changed) | ||
| id: list-changed | ||
| run: | | ||
| ct version | ||
| changed=$(ct list-changed --config charts/.ci/ct-config-gha.yaml) |
| contains(steps.list-changed.outputs.changed_charts, 'charts/gha-runner-scale-set-controller-experimental') || | ||
| contains(steps.list-changed.outputs.changed_charts, 'charts/gha-runner-scale-set-experimental') | ||
| run: | | ||
| helm plugin install https://github.com/helm-unittest/helm-unittest.git |
| - name: Run helm-unittest (gha-runner-scale-set-controller-experimental) | ||
| if: contains(steps.list-changed.outputs.changed_charts, 'charts/gha-runner-scale-set-controller-experimental') | ||
| run: | | ||
| helm unittest ./charts/gha-runner-scale-set-controller-experimental/ | ||
|
|
||
| - name: Run helm-unittest (gha-runner-scale-set-experimental) |
| - name: Run helm-unittest (gha-runner-scale-set-controller-experimental) | ||
| if: contains(steps.list-changed.outputs.changed_charts, 'charts/gha-runner-scale-set-controller-experimental') | ||
| run: | | ||
| helm unittest ./charts/gha-runner-scale-set-controller-experimental/ | ||
|
|
|
@copilot resolve the merge conflicts in this pull request |
…hart.yaml Co-authored-by: nikola-jokic <97525037+nikola-jokic@users.noreply.github.com>
Resolved the merge conflict in |
No description provided.