Upgrade action to use Node 24#712
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the GitHub Action from Node 20 to Node 24, ensuring compatibility with the latest Node.js features and improvements. The upgrade includes updating the Node.js engine requirements, TypeScript definitions, and GitHub Actions runtime configuration.
- Updates Node.js engine requirement from >=20.0.0 to >=24.0.0
- Updates @types/node from 24.0.12 to 24.1.0
- Changes GitHub Action runtime from node20 to node24
- Normalizes quote style in license files from double quotes to single quotes
Reviewed Changes
Copilot reviewed 26 out of 29 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates Node.js engine requirement and @types/node version |
| action.yml | Changes GitHub Action runtime from node20 to node24 |
| .licenses/*.dep.yml | Normalizes quote style in license metadata files |
| .github/workflows/post-dependabot.yml | Removes empty line in workflow file |
|
Hi @salmanmkc thanks for putting this together and sorry we missed it. Can I help move this along at all? Or happy to approve if you can get the conflicts resolved. I wonder if we need this upgrade to get #723 working as well |
|
Since March 10, the following message is displayed on each add-to-project action execution : Since Node 24 will be used from June 2nd anyway, this PR sounds useful :) |
|
End of April deprecation deadline is approaching. It must be resolved. @salmanmkc @nasquasha do you need help with moving it forward? I see some conflicts. Is the only thing needed is to resolve those? Other tests are passing - meaning all good with node 24? |
Resolve merge conflicts with main branch. Keep main's dependency and tooling upgrades while updating the action runtime from node20 to node24 and setting engines.node to >=24.0.0. Regenerated package-lock.json, dist bundle, and license cache.
Solved merge conflicts now, should be good to go |
Update the project to utilize Node 24, since runner now supports node24. https://github.com/actions/runner/releases/tag/v2.327.1