Skip to content

Upgrade action to use Node 24#712

Merged
nasquasha merged 2 commits intoactions:mainfrom
salmanmkc:node24
May 1, 2026
Merged

Upgrade action to use Node 24#712
nasquasha merged 2 commits intoactions:mainfrom
salmanmkc:node24

Conversation

@salmanmkc
Copy link
Copy Markdown
Contributor

@salmanmkc salmanmkc commented Jul 25, 2025

Update the project to utilize Node 24, since runner now supports node24. https://github.com/actions/runner/releases/tag/v2.327.1

@salmanmkc salmanmkc marked this pull request as ready for review August 8, 2025 06:50
Copilot AI review requested due to automatic review settings August 8, 2025 06:50
@salmanmkc salmanmkc requested a review from a team as a code owner August 8, 2025 06:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the GitHub Action from Node 20 to Node 24, ensuring compatibility with the latest Node.js features and improvements. The upgrade includes updating the Node.js engine requirements, TypeScript definitions, and GitHub Actions runtime configuration.

  • Updates Node.js engine requirement from >=20.0.0 to >=24.0.0
  • Updates @types/node from 24.0.12 to 24.1.0
  • Changes GitHub Action runtime from node20 to node24
  • Normalizes quote style in license files from double quotes to single quotes

Reviewed Changes

Copilot reviewed 26 out of 29 changed files in this pull request and generated no comments.

File Description
package.json Updates Node.js engine requirement and @types/node version
action.yml Changes GitHub Action runtime from node20 to node24
.licenses/*.dep.yml Normalizes quote style in license metadata files
.github/workflows/post-dependabot.yml Removes empty line in workflow file

@nasquasha
Copy link
Copy Markdown
Contributor

Hi @salmanmkc thanks for putting this together and sorry we missed it. Can I help move this along at all? Or happy to approve if you can get the conflicts resolved. I wonder if we need this upgrade to get #723 working as well

@jf-cbd
Copy link
Copy Markdown

jf-cbd commented Apr 15, 2026

Since March 10, the following message is displayed on each add-to-project action execution :
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/add-to-project@v1.0.2. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

Since Node 24 will be used from June 2nd anyway, this PR sounds useful :)

@spron-in
Copy link
Copy Markdown

End of April deprecation deadline is approaching. It must be resolved.

@salmanmkc @nasquasha do you need help with moving it forward? I see some conflicts. Is the only thing needed is to resolve those? Other tests are passing - meaning all good with node 24?

Resolve merge conflicts with main branch. Keep main's dependency
and tooling upgrades while updating the action runtime from node20
to node24 and setting engines.node to >=24.0.0.

Regenerated package-lock.json, dist bundle, and license cache.
@salmanmkc
Copy link
Copy Markdown
Contributor Author

Hi @salmanmkc thanks for putting this together and sorry we missed it. Can I help move this along at all? Or happy to approve if you can get the conflicts resolved. I wonder if we need this upgrade to get #723 working as well

Solved merge conflicts now, should be good to go

Copy link
Copy Markdown
Contributor

@nasquasha nasquasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @salmanmkc !

@nasquasha nasquasha added this pull request to the merge queue May 1, 2026
Merged via the queue into actions:main with commit 5afcf98 May 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to Node 24

5 participants