Simplified logic for handling "no files" upload notification

[fearphage]

Changes

• Created a constant that maps the NoFileOptions to their corresponding core methods
• Switched to early exit/return pattern to further simplify and de-indent the code
  Everything after the return statement is just white-space changes.

Note

There is no change in functionality here.

[Copilot]

Pull Request Overview

This PR simplifies the logic for handling "no files" upload notifications by replacing a switch statement with a lookup table pattern and implementing an early return strategy.

• Replaced switch statement with a constant mapping NoFileOptions to core methods
• Introduced early exit pattern with return statement to reduce code indentation
• Simplified control flow by eliminating the else block after the early return

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/upload/constants.ts	Added NoFileFunctionMap constant mapping enum values to core functions
src/upload/upload-artifact.ts	Replaced switch statement with map lookup and implemented early return pattern

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The NoFileFunctionMap could potentially be called with an undefined key if inputs.ifNoFilesFound contains an unexpected value. Consider adding a type annotation or default case to handle this scenario gracefully.

Suggested change

	} as const
	} as const
	/**
	* Safely retrieves the function for the given NoFileOptions value.
	* Defaults to warning if the value is unrecognized.
	*/
	export function getNoFileFunction(
	option: string
	): typeof setFailed | typeof info | typeof warning {
	if (option === NoFileOptions.error) {
	return setFailed;
	} else if (option === NoFileOptions.ignore) {
	return info;
	} else if (option === NoFileOptions.warn) {
	return warning;
	} else {
	// Default to warning for unexpected values
	warning(`Unknown if-no-files-found option: ${option}, defaulting to 'warn'.`);
	return warning;
	}
	}

[Copilot]

Using optional chaining here means that if inputs.ifNoFilesFound is an unexpected value, the function will silently do nothing instead of providing feedback about the invalid option. Consider adding explicit error handling for unsupported values.

Suggested change

	NoFileFunctionMap[inputs.ifNoFilesFound]?.(
	`No files were found with the provided path: ${inputs.searchPath}. No artifacts will be uploaded.`
	)
	const noFileHandler = NoFileFunctionMap[inputs.ifNoFilesFound];
	if (noFileHandler) {
	noFileHandler(
	`No files were found with the provided path: ${inputs.searchPath}. No artifacts will be uploaded.`
	);
	} else {
	core.setFailed(
	`Invalid value for 'if-no-files-found': '${inputs.ifNoFilesFound}'. Supported options are: ${Object.keys(NoFileFunctionMap).join(', ')}.`
	);
	}

[fearphage]

Both of the Copilot suggestions would alter the current functionality. That goes against the current intent.

[Tyszek343]

Changes

• Created a constant that maps the NoFileOptions to their corresponding core methods
• Switched to early exit/return pattern to further simplify and de-indent the code
  Everything after the return statement is just white-space changes.

[!NOTE]

There is no change in functionality here.