Implement overwrite behavior for skip archive artifact#770
Open
kazutoiris wants to merge 1 commit intoactions:mainfrom
Open
Implement overwrite behavior for skip archive artifact#770kazutoiris wants to merge 1 commit intoactions:mainfrom
kazutoiris wants to merge 1 commit intoactions:mainfrom
Conversation
When archive is set to false and overwrite is true, it now deletes existing artifact by filename before uploading new one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the behavior of the upload action when
archiveis set tofalseandoverwriteis set totrue.Previously, the overwrite logic only deletes existing artifacts by the artifact name.
According to
action.yml:upload-artifact/action.yml
Line 52 in bbbca2d
Therefore, when
overwrite: trueis enabled, the action must delete the existing artifact using the filename as the artifact name, rather than using thenameinput parameter (which is ignored).Related Issues
Fixes #769