Conversation
Collaborator
Author
|
cc @anonrig. Is it fine to use AI for these kinds of tasks? The test case contains invalid utf-8 which cannot be deserialized as |
Member
I think it's fine to use AI in any sense if there is a human in the loop |
anonrig
approved these changes
Mar 3, 2026
Member
anonrig
left a comment
anonrig
left a comment
There was a problem hiding this comment.
As part of this PR, can we also add this github workflow which will automatically update/open PR for web platform test(WPT) files, whenever they change on upstream?
https://github.com/ada-url/ada/blob/main/.github/workflows/wpt-updater.yml
Member
|
I'll merge this PR and we can add it on a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used AI to port tests from https://github.com/ada-url/ada/tree/main/tests
I reviewed the whole changaes and I feel like it's good to go, but I'll verify one more time if tests are completely identical after opening the PR.