fix(security): make get_products retry-safe - #6115
Draft
bokelley wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
get_productsas state-mutating and require a caller-owned idempotency key across schemas, manifests, MCP/V5/V6 routes, Addie, evaluation tools, docs, examples, and compliance fixturesINVALID_REQUESTfield mapping through V6Why
get_productsis polymorphic: wholesale discovery is read-like, but async execution, refinement, and proposal finalization can create tasks, persist session state, hold inventory, and create insertion orders. Treating the whole task as read-only allowed ambiguous retries to repeat those side effects.Impact
Callers must now send a valid
idempotency_keyon everyget_productsrequest and reuse it only for exact retries. Existing 3.1 behavior remains documented as a compatibility grace period only for guaranteed side-effect-free synchronous reads.Validation
git diff --checkRoot
package.json,package-lock.json, and immutable versioneddistartifacts are intentionally unchanged.