fix(security): enforce Slack knowledge ACLs - #6117
Draft
bokelley wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security impact
Authenticated web and voice callers previously inherited Slack knowledge handlers created without Slack identity. In that state,
undefineddisabled private-channel filtering, and channel activity had no row-level ACL at all. This could expose private working-group messages, participants, and permalinks.The new discriminated access scope binds linked callers to their Slack allowlist and treats every absent/error context as public-only. Slack, legacy, web, and Tavus paths now install atomic request-scoped tool definitions and handlers.
Validation
git diff --checkpassedFollow-up
Private/public classification currently depends on retaining the indexed channel's
working_groups.slack_channel_idmapping. Persisting privacy-at-index or cleaning stale rows during channel remaps is separate lifecycle hardening and is not introduced by this change.