Skip to content

feat: support dev orgs with runtime, in addition to entp#134

Merged
MichaelGoberling merged 1 commit into
masterfrom
feat/support-rt-dev-orgs
May 15, 2026
Merged

feat: support dev orgs with runtime, in addition to entp#134
MichaelGoberling merged 1 commit into
masterfrom
feat/support-rt-dev-orgs

Conversation

@MichaelGoberling
Copy link
Copy Markdown
Contributor

@MichaelGoberling MichaelGoberling commented May 15, 2026

Description

  • Added getOrganizationFeatures(orgId) SDK method that calls the dev console and returns the org's feature flags

Related:

Related Issue

Motivation and Context

How Has This Been Tested?

Locally linked everything and tested with a dev and entp org

aio login 
aio console org list
aio console org select
aio app init 

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 PR Reviewer

The diff introduces a well-structured getOrganizationFeatures method that bypasses the swagger client to call the Console BFF directly. The implementation is clean, error handling is consistent with the rest of the SDK, and test coverage is thorough. One minor issue: the res variable from fetchWithRetry is referenced after the if (!res.ok) block to build the return object, but res is a closure variable so it's fine — however there is a subtle issue where res.headers is accessed on the resolved response after the if block but the Headers object's iterability depends on the fetch implementation. This is a very minor concern and the code is overall high quality.

LGTM! This PR looks good to merge.


💡 How to re-trigger

Comment /review or /pr-reviewer on this PR

@MichaelGoberling MichaelGoberling changed the title feat: support dev orgs with runtime, inaddition to entp feat: support dev orgs with runtime, in addition to entp May 15, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@MichaelGoberling MichaelGoberling merged commit b66cde9 into master May 15, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants