Skip to content

fix(autocomplete): apply virtual focus to first item on IME composition input #10156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lucas20000903 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix(autocomplete): apply virtual focus to first item on IME composition input #10156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/react-aria/src/autocomplete/useAutocomplete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,14 @@ export function useAutocomplete<T>(
let onChange = (value: string) => {
// Tell wrapped collection to focus the first element in the list when typing forward and to clear focused key when modifying the text via
// copy paste/backspacing/undo/redo for screen reader announcements
if (lastInputType.current === 'insertText' && !disableAutoFocusFirst) {
if (
(lastInputType.current === 'insertText' ||
// IME composition (e.g. CJK input) reports 'insertCompositionText'/'insertFromComposition'
// instead of 'insertText'. Treat these as forward typing so the first item gets virtual focus.
lastInputType.current === 'insertCompositionText' ||
lastInputType.current === 'insertFromComposition') &&
!disableAutoFocusFirst
) {
focusFirstItem();
} else if (
lastInputType.current &&
Expand Down