chore: Ai components followup#10162
Merged
Merged
Conversation
|
Build successful! 🎉 |
## API Changes
@react-spectrum/s2-ai/@react-spectrum/s2-ai:BasicHorizontalCard BasicHorizontalCard {
- UNSAFE_className?: UnsafeClassName
- UNSAFE_style?: CSSProperties
children: ReactNode | (CardRenderProps) => ReactNode
density?: 'compact' | 'regular' | 'spacious' = 'regular'
download?: boolean | string
href?: Href
hrefLang?: string
id?: Key
isDisabled?: boolean
onAction?: () => void
onPress?: (PressEvent) => void
onPressChange?: (boolean) => void
onPressEnd?: (PressEvent) => void
onPressStart?: (PressEvent) => void
onPressUp?: (PressEvent) => void
ping?: string
referrerPolicy?: HTMLAttributeReferrerPolicy
rel?: string
routerOptions?: RouterOptions
size?: 'XS' | 'S' | 'M' | 'L' | 'XL' = 'M'
- styles?: StylesProp
+ styles?: StyleString
target?: HTMLAttributeAnchorTarget
textValue?: string
value?: T
variant?: 'primary' | 'secondary' | 'tertiary' | 'quiet' = 'primary'/@react-spectrum/s2-ai:HorizontalCard HorizontalCard {
- UNSAFE_className?: UnsafeClassName
- UNSAFE_style?: CSSProperties
children: ReactNode | (CardRenderProps) => ReactNode
density?: 'compact' | 'regular' | 'spacious' = 'regular'
download?: boolean | string
href?: Href
hrefLang?: string
id?: Key
isDisabled?: boolean
onAction?: () => void
onPress?: (PressEvent) => void
onPressChange?: (boolean) => void
onPressEnd?: (PressEvent) => void
onPressStart?: (PressEvent) => void
onPressUp?: (PressEvent) => void
ping?: string
referrerPolicy?: HTMLAttributeReferrerPolicy
rel?: string
routerOptions?: RouterOptions
size?: 'XS' | 'S' | 'M' | 'L' | 'XL' = 'M'
- styles?: StylesProp
+ styles?: StyleString
target?: HTMLAttributeAnchorTarget
textValue?: string
value?: T
variant?: 'primary' | 'secondary' | 'tertiary' | 'quiet' = 'primary'/@react-spectrum/s2-ai:MessageFeedback MessageFeedback {
- UNSAFE_className?: UnsafeClassName
- UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
defaultValue?: MessageFeedbackValue
id?: string
isDisabled?: boolean
onChange?: (MessageFeedbackValue) => void
slot?: string | null
- styles?: StylesProp
+ styles?: StyleString
thumbDownLabel?: string
thumbUpLabel?: string
value?: MessageFeedbackValue
}/@react-spectrum/s2-ai:MessageSuggestion MessageSuggestion {
- UNSAFE_className?: UnsafeClassName
- UNSAFE_style?: CSSProperties
aria-controls?: string
aria-current?: boolean | 'true' | 'false' | 'page' | 'step' | 'location' | 'date' | 'time'
aria-describedby?: string
aria-details?: string
aria-disabled?: boolean | 'true' | 'false'
aria-expanded?: boolean | 'true' | 'false'
aria-haspopup?: boolean | 'menu' | 'listbox' | 'tree' | 'grid' | 'dialog' | 'true' | 'false'
aria-label?: string
aria-labelledby?: string
aria-pressed?: boolean | 'true' | 'false' | 'mixed'
autoFocus?: boolean
children: ReactNode
excludeFromTabOrder?: boolean
form?: string
formAction?: ButtonHTMLAttributes<HTMLButtonElement>['formAction']
formEncType?: string
formMethod?: string
formNoValidate?: boolean
formTarget?: string
id?: string
name?: string
onBlur?: (FocusEvent<Target>) => void
onClick?: (MouseEvent<FocusableElement>) => void
onFocus?: (FocusEvent<Target>) => void
onFocusChange?: (boolean) => void
onHoverChange?: (boolean) => void
onHoverEnd?: (HoverEvent) => void
onHoverStart?: (HoverEvent) => void
onKeyDown?: (KeyboardEvent) => void
onKeyUp?: (KeyboardEvent) => void
onPress?: (PressEvent) => void
onPressChange?: (boolean) => void
onPressEnd?: (PressEvent) => void
onPressStart?: (PressEvent) => void
onPressUp?: (PressEvent) => void
preventFocusOnPress?: boolean
render?: DOMRenderFunction<keyof React.JSX.IntrinsicElements, ButtonRenderProps>
size?: 'S' | 'M' | 'L' | 'XL'
slot?: string | null
- styles?: StylesProp
+ styles?: StyleString
type?: 'button' | 'submit' | 'reset' = 'button'
value?: string
}/@react-spectrum/s2-ai:MessageSuggestionContext-MessageSuggestionContext {
- UNTYPED
-}/@react-spectrum/s2-ai:MessageSuggestionList MessageSuggestionList {
- UNSAFE_className?: UnsafeClassName
- UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
children: ReactNode
id?: string
size?: 'S' | 'M' | 'L' | 'XL'
slot?: string | null
- styles?: StylesProp
+ styles?: StyleString
title: string
}/@react-spectrum/s2-ai:MessageSuggestionListContext-MessageSuggestionListContext {
- UNTYPED
-}/@react-spectrum/s2-ai:ResponseStatus ResponseStatus {
- UNSAFE_className?: UnsafeClassName
- UNSAFE_style?: CSSProperties
children: ReactNode
defaultExpanded?: boolean
density?: 'compact' | 'regular' | 'spacious' = 'regular'
id?: Key
isDisabled?: boolean
isExpanded?: boolean
isLoading?: boolean
onExpandedChange?: (boolean) => void
size?: 'S' | 'M' | 'L' | 'XL' = 'M'
slot?: string | null
- styles?: StylesProp
+ styles?: StyleString
}/@react-spectrum/s2-ai:ResponseStatusPanel ResponseStatusPanel {
- UNSAFE_className?: UnsafeClassName
- UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
children: React.ReactNode
id?: string
label?: ReactNode
labelElementType?: ElementType = 'label'
role?: 'group' | 'region' = 'group'
+ styles?: StyleString
}/@react-spectrum/s2-ai:UserMessage UserMessage {
- UNSAFE_className?: UnsafeClassName
- UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
children: ReactNode
id?: string
slot?: string | null
- styles?: StylesProp
+ styles?: StyleString
} |
reidbarber
approved these changes
Jun 5, 2026
devongovett
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-ups from #10095
main things:
CenterBaselinefrom S2useSpectrumContextProps. make it simpler for now by removing contexts. can decide to add them latergetAllowedOverrides(), instead we allow users to override anything. i stripped out most of everything intypes.tsbut keptStyleStringbcmergeStylesexpects aStyleString. RemovedUNSAFE_classNameandUNSAFE_stylesince we're going to allow everything✅ Pull Request Checklist:
📝 Test Instructions:
Spot check storybook
🧢 Your Project: