Skip to content

fix: tweaks to prose from design - #10375

Merged
snowystinger merged 4 commits into
mainfrom
prose-design-feedback
Jul 29, 2026
Merged

fix: tweaks to prose from design#10375
snowystinger merged 4 commits into
mainfrom
prose-design-feedback

Conversation

@snowystinger

Copy link
Copy Markdown
Member

Closes

More closely aligns text in list with the text in a quote (horizontal padding)
Makes the padding an even 1em for a bunch of things instead of .888889em that the tokens had specified

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot

rspbot commented Jul 28, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Jul 28, 2026

Copy link
Copy Markdown

borderWidth: 0,
borderBottomWidth: getToken('border-width-100'),
borderStyle: 'solid',
height: '32px',

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do people like this better?
or would y'all prefer i set a minHeight of '32' on both the th and td?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous commit's build to see it without the height at all and it's decided by content
see the commit after this comment to see the rows and headers with the same default height

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like the one with the default minHeights

@rspbot

rspbot commented Jul 28, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Jul 28, 2026

Copy link
Copy Markdown

Agent Skills Changes

Modified (2)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/4e2ad410be73fb5ba5b8ac44b200e6483f106026/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/4e2ad410be73fb5ba5b8ac44b200e6483f106026/

@snowystinger snowystinger added release small review Easy to review PR labels Jul 28, 2026
@snowystinger
snowystinger added this pull request to the merge queue Jul 29, 2026
Merged via the queue into main with commit 1259843 Jul 29, 2026
31 checks passed
@snowystinger
snowystinger deleted the prose-design-feedback branch July 29, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release small review Easy to review PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants