fix: tweaks to prose from design - #10375
Merged
Merged
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
commented
Jul 28, 2026
| borderWidth: 0, | ||
| borderBottomWidth: getToken('border-width-100'), | ||
| borderStyle: 'solid', | ||
| height: '32px', |
Member
Author
There was a problem hiding this comment.
do people like this better?
or would y'all prefer i set a minHeight of '32' on both the th and td?
Member
Author
There was a problem hiding this comment.
see previous commit's build to see it without the height at all and it's decided by content
see the commit after this comment to see the rows and headers with the same default height
Member
There was a problem hiding this comment.
I personally like the one with the default minHeights
|
Build successful! 🎉 |
Agent Skills ChangesModified (2)
InstallReact Spectrum S2: React Aria: |
LFDanLu
approved these changes
Jul 28, 2026
devongovett
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
More closely aligns text in list with the text in a quote (horizontal padding)
Makes the padding an even 1em for a bunch of things instead of .888889em that the tokens had specified
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: