Server v2.0.1#2626
Merged
Merged
Conversation
The async job cleanup path used Hadoop's default file system to delete per-job directories, which failed with "Wrong FS" when the warehouse was on a non-default scheme such as s3a://. Route the deletion through the existing JobDirectoryFileSystem so the file system is resolved from the warehouse URI. Fixes #2612.
The unit-test Spring context does not component-scan the server's io package, so the JobDirectoryFileSystem dependency required by the test jobProvider bean could not be resolved. This caused every unit test importing FhirServerTestConfiguration to fail context loading. Provide an explicit JobDirectoryFileSystem bean in the test configuration, built from the running SparkSession and the existing warehouse and database name properties.
Add a regression test that configures a Hadoop default file system on a different scheme than the warehouse, exercising the failure mode where the previous implementation resolved the default file system and failed with "Wrong FS". Clarify that the existing local-only test covers the happy path.
Capture the JobProvider log via a Logback ListAppender so the test verifies the documented warning behaviour rather than only asserting that no exception is thrown.
Lock in that a warehouse URL configured with a trailing slash composes the same job directory as one without, with no empty path segment, so the behaviour cannot regress if path normalisation changes.
Resolve job directory file system from warehouse URI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.