[AAASM-5798] ✨ (scripts): Roll out the claim-vocabulary gate to python-sdk - #322
Open
Chisanan232 wants to merge 3 commits into
Open
[AAASM-5798] ✨ (scripts): Roll out the claim-vocabulary gate to python-sdk#322Chisanan232 wants to merge 3 commits into
Chisanan232 wants to merge 3 commits into
Conversation
AAASM-5798 / AAASM-5599. python-sdk had no claim linter. Per AAASM-5795's federation-by-convention decision this is a one-time port (agent-assembly's AAASM-5679, via docs Hub's AAASM-5797) -- Markdown corpus, the same ADR 0033 forbidden-design-7 absolutes and undifferentiated-verb rule, adapted to this repo's own scope (docs/**, README/CONTRIBUTING/SECURITY.md; excludes quickstart_snippets/ -- vendored from the examples repo, same reasoning ruff.toml already uses -- and verification-reports/**). This file now diverges independently from the two it was ported from. None of its rules are waivable -- claim-vocabulary.md 7.1 states CLAIM-ABS-*/CLAIM-VERB-01 are unwaivable everywhere.
Four instances of the literal phrase 'every tool call' (ADR 0033 forbidden design 7, CLAIM-ABS-07, unwaivable) reworded to 'each tool call' -- the underlying claim was already accurate and correctly scoped to the wrapped agent; only the banned trigger phrase changed. One 'no code changes' (CLAIM-ABS-08) in docs/concepts/index.md reworded to the same bounded phrasing already used for this exact fact elsewhere this session (official-website's SDKs blog post, docs Hub's faq.md).
Path-filtered to README/CONTRIBUTING/SECURITY.md and docs/**, where
ci.yaml's own allow-list otherwise leaves docs-only PRs with no CI at
all ('Docs-only PRs run NO CI', this repo's own CLAUDE.md). Full-tree,
not diff-scoped -- the blocking baseline is zero as of this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Ticket
https://lightning-dust-mite.atlassian.net/browse/AAASM-5798
What changed
python-sdk had no claim linter, unlike agent-assembly, official-website, and
now docs Hub (AAASM-5797). Per AAASM-5795's federation-by-convention
decision this is a one-time port (agent-assembly's AAASM-5679, via docs
Hub's AAASM-5797) -- Markdown corpus, the same ADR 0033 forbidden-design-7
absolutes and undifferentiated-verb rule, adapted to this repo's own scope.
This file diverges independently from here.
scripts/check_claim_vocabulary.py(new) -- scoped todocs/**,README.md,CONTRIBUTING.md,SECURITY.md. Excludesquickstart_snippets/(vendored verbatim from theexamplesrepo -- thisrepo doesn't author that prose, same reasoning
ruff.tomlalreadyexcludes it for) and
verification-reports/**.README.md,docs/index.md,docs/concepts/index.md,docs/examples/langchain-basic-agent.md,docs/examples/llamaindex-tool-policy.md-- reworded. Four were theliteral phrase "every tool call" (
CLAIM-ABS-07, unwaivable); theunderlying claim was already true and correctly scoped to the wrapped
agent, so only the banned trigger phrase changed, to "each tool call".
One was "no code changes" (
CLAIM-ABS-08), reworded to the same boundedphrasing already used for this exact fact elsewhere this session
(official-website's SDKs blog post, docs Hub's
faq.md)..github/workflows/claim-vocabulary-check.yml(new) -- path-filtered tothe same scope. This repo's own
CLAUDE.mdnotesci.yaml's pathallow-list excludes
docs/**/*.mdentirely ("Docs-only PRs run NO CI"),so this fills a real gap, not an added redundant gate.
None of this file's rules are waivable --
claim-vocabulary.md§7.1 statesCLAIM-ABS-*/CLAIM-VERB-01are unwaivable everywhere, not just in therepo that specification lives in.
How to verify
python3 scripts/check_claim_vocabulary.py --selftest-- 45/45.python3 scripts/check_claim_vocabulary.py --root .-- 45 files scanned,0 blocking, 8 finding (informational, matches agent-assembly's own posture
toward
CLAIM-VERB-01/bareCLAIM-ABS-06/CLAIM-ABS-11)."This SDK catches everything, with no exceptions." into
docs/index.md,ran the scanner -- 1 real
blockinghit,CLAIM-ABS-01. Reverted; cleanscan restored.
ruff check/ruff format --checkon the new script -- clean. (Notcovered by
mypy'spackages =scope, which lists onlyagent_assemblyand
test.)python scripts/check_readme_version.py --check-- unaffected, stillpasses (README wording change did not touch the version-anchored sample
output).
Related
Closes AAASM-5798 (python-sdk slice of AAASM-5798), part of AAASM-5599 via
AAASM-5795's decision. node-sdk, go-sdk, arena and examples are the
remaining repos in AAASM-5798's scope, each its own PR.