chore(dashboard): AIN-87/88 · honest-disable fake-toast Settings buttons#41
Merged
Merged
Conversation
Memory #5 (honest-deferred > half-shipped fakes) cleanup pass on Settings tabs whose toast handlers promised UX backed by endpoints that don't exist: - Delete dead KEY_ROWS table branch + its rotate/revoke fake-toast handlers. KEY_ROWS was hardcoded [] so the table never rendered, but the rotate/revoke buttons within the never-rendered branch toast "lands D6" — multi-key CRUD actually needs new api_keys schema (AIN-87, multi-day). - Tenant tab "Save changes" button → disabled with honest "post-Seed" label + tooltip pointing at the missing PATCH /v1/tenants/{id} surface. - Compliance tab "Export bundle now" + "Configure schedule" buttons → disabled. Annex IV export endpoint doesn't exist; public audit chain at /v1/audit/public is the current honest surface. No behavior changes for surfaces that work today (Mint Card via /agents, spend-policy editor, audit feed, etc). Co-Authored-By: Claude <noreply@anthropic.com>
|
You have used all Bugbot PR reviews included in your free trial for your GitHub account on this workspace. To continue using Bugbot reviews, enable Bugbot for your team in the Cursor dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Memory #5 honest-deferred pass on Settings tabs. Removes/disables fake-toast handlers whose backing endpoints don't exist.
KEY_ROWS = []hardcoded → table never rendered, but rotate/revoke buttons inside toast "lands D6" — multi-key CRUD requires newapi_keysschema (AIN-87, multi-day).PATCH /v1/tenants/{id}endpoint exists. Label now: "Save changes (post-Seed)" + tooltip explains./v1/audit/publicas the honest current surface.What still works (untouched)
MintAgentTrigger→MintAgentModal→POST /v1/agents/signup)PATCH /v1/agents/{id}/spend-policy)/agentspointing atainfera installWhy this clean-up
After verifying AIN-87 schema reality (singular
TenantORM.api_key_hash) and AIN-88 endpoint reality (no Annex IV export), the dashboard's rotate/revoke/save toasts were promising functionality the backend can't deliver in a single session. Honest disabled buttons + post-Seed labels beat half-shipped fakes per founder guidance (Memory #5).Test plan
pnpm -F dashboard typecheck— passes🤖 Generated with Claude Code