Skip to content

Fix iOS bridge crash by replacing BOOL* with BOOL in exported methods #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexkhazzam wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix iOS bridge crash by replacing BOOL* with BOOL in exported methods #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions ios/TextToSpeech/TextToSpeech.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ + (BOOL)requiresMainQueueSetup
[[AVAudioSession sharedInstance]
setCategory:AVAudioSessionCategoryPlayback
mode:AVAudioSessionModeVoicePrompt
// This will pause a spoken audio like podcast or audiobook and duck the volume for music
options:AVAudioSessionCategoryOptionInterruptSpokenAudioAndMixWithOthers
error:nil
];
Expand All @@ -94,11 +93,11 @@ + (BOOL)requiresMainQueueSetup
resolve([NSNumber numberWithUnsignedLong:utterance.hash]);
}

RCT_EXPORT_METHOD(stop:(BOOL *)onWordBoundary resolve:(RCTPromiseResolveBlock)resolve reject:(__unused RCTPromiseRejectBlock)reject)
RCT_EXPORT_METHOD(stop:(BOOL)onWordBoundary resolve:(RCTPromiseResolveBlock)resolve reject:(__unused RCTPromiseRejectBlock)reject)
{
AVSpeechBoundary boundary;

if(onWordBoundary != NULL && onWordBoundary) {
if(onWordBoundary) {
boundary = AVSpeechBoundaryWord;
} else {
boundary = AVSpeechBoundaryImmediate;
Expand All @@ -109,11 +108,11 @@ + (BOOL)requiresMainQueueSetup
resolve([NSNumber numberWithBool:stopped]);
}

RCT_EXPORT_METHOD(pause:(BOOL *)onWordBoundary resolve:(RCTPromiseResolveBlock)resolve reject:(__unused RCTPromiseRejectBlock)reject)
RCT_EXPORT_METHOD(pause:(BOOL)onWordBoundary resolve:(RCTPromiseResolveBlock)resolve reject:(__unused RCTPromiseRejectBlock)reject)
{
AVSpeechBoundary boundary;

if(onWordBoundary != NULL && onWordBoundary) {
if(onWordBoundary) {
boundary = AVSpeechBoundaryWord;
} else {
boundary = AVSpeechBoundaryImmediate;
Expand All @@ -131,8 +130,7 @@ + (BOOL)requiresMainQueueSetup
resolve([NSNumber numberWithBool:continued]);
}


RCT_EXPORT_METHOD(setDucking:(BOOL *)ducking
RCT_EXPORT_METHOD(setDucking:(BOOL)ducking
resolve:(RCTPromiseResolveBlock)resolve
reject:(__unused RCTPromiseRejectBlock)reject)
{
Expand All @@ -148,7 +146,6 @@ + (BOOL)requiresMainQueueSetup
resolve(@"success");
}


RCT_EXPORT_METHOD(setDefaultLanguage:(NSString *)language
resolve:(RCTPromiseResolveBlock)resolve
reject:(RCTPromiseRejectBlock)reject)
Expand Down Expand Up @@ -178,7 +175,7 @@ + (BOOL)requiresMainQueueSetup
}

RCT_EXPORT_METHOD(setDefaultRate:(float)rate
skipTransform:(BOOL *)skipTransform // not used, compatibility with Android native module signature
skipTransform:(BOOL)skipTransform
resolve:(RCTPromiseResolveBlock)resolve
reject:(RCTPromiseRejectBlock)reject)
{
Expand Down