docs: add Registry v2 migration runbook#789
Conversation
WalkthroughNew migration runbook documenting end-to-end procedures to migrate ACP image workloads from legacy ACP Registry to Registry v2, including discovery, inventory, two migration scenarios (filesystem/object storage reuse and image copy), shell-based metadata backfill implementation, verification, and rollback guidance. ChangesACP Registry v2 Migration Runbook
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/en/solutions/ACP_Registry_v2_Migration_Runbook.mdx (1)
458-464: 💤 Low valueConsider adding timeout protection to wait loops.
The
whileloops waiting for deployment removal could run indefinitely if the deployment doesn't get removed as expected. While acceptable for supervised operations where an operator can interrupt, adding a max iteration count or timestamp check would make the runbook more robust.Example enhancement:
max_wait=60 # 5 minutes elapsed=0 while ac get deployment image-registry -n "$MODERN_REGISTRY_NAMESPACE" >/dev/null 2>&1; do sleep 5 elapsed=$((elapsed + 5)) if [ $elapsed -ge $max_wait ]; then echo "Timeout waiting for image-registry deployment removal" >&2 exit 1 fi doneThis same pattern applies to similar wait loops at lines 518-524, 543-549, and 591-597.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/en/solutions/ACP_Registry_v2_Migration_Runbook.mdx` around lines 458 - 464, The two wait loops that poll `ac get deployment image-registry -n "$MODERN_REGISTRY_NAMESPACE"` and `ac get deployment image-api-server -n "$MODERN_REGISTRY_NAMESPACE"` should include timeout protection so they don't hang indefinitely: add a max-wait counter/timestamp (e.g., `max_wait` and `elapsed` or `deadline`), increment elapsed on each sleep, and if the timeout is reached print a clear error and exit non‑zero; apply the same pattern to the other similar loops referenced (the blocks waiting on the same deployments at the later locations) to fail fast and surface a clear message instead of looping forever.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/en/solutions/ACP_Registry_v2_Migration_Runbook.mdx`:
- Around line 458-464: The two wait loops that poll `ac get deployment
image-registry -n "$MODERN_REGISTRY_NAMESPACE"` and `ac get deployment
image-api-server -n "$MODERN_REGISTRY_NAMESPACE"` should include timeout
protection so they don't hang indefinitely: add a max-wait counter/timestamp
(e.g., `max_wait` and `elapsed` or `deadline`), increment elapsed on each sleep,
and if the timeout is reached print a clear error and exit non‑zero; apply the
same pattern to the other similar loops referenced (the blocks waiting on the
same deployments at the later locations) to fail fast and surface a clear
message instead of looping forever.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1aa028db-f4c3-4c98-9e4a-245b1c3258d0
📒 Files selected for processing (1)
docs/en/solutions/ACP_Registry_v2_Migration_Runbook.mdx
Summary by CodeRabbit