Add New TextViewer#3036
Merged
fabiencastan merged 7 commits intodevelopfrom Mar 18, 2026
Merged
Conversation
Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add TextViewer for displaying text files
Add TextViewer for displaying text file outputs from nodes
Mar 10, 2026
Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Copilot
AI
changed the title
Add TextViewer for displaying text file outputs from nodes
Add TextViewer and merge with ImageViewer into a shared tabbed panel
Mar 10, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3036 +/- ##
===========================================
+ Coverage 83.07% 83.09% +0.01%
===========================================
Files 72 72
Lines 9657 9684 +27
===========================================
+ Hits 8023 8047 +24
- Misses 1634 1637 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Copilot
AI
changed the title
Add TextViewer and merge with ImageViewer into a shared tabbed panel
Merge ImageViewer and TextViewer into a shared tabbed panel with independent visibility controls
Mar 11, 2026
Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Copilot
AI
changed the title
Merge ImageViewer and TextViewer into a shared tabbed panel with independent visibility controls
View menu: separate ImageViewer/TextViewer toggles; open text-only node outputs in Text Viewer on double-click
Mar 11, 2026
Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Copilot
AI
changed the title
View menu: separate ImageViewer/TextViewer toggles; open text-only node outputs in Text Viewer on double-click
Open text-only output nodes in Text Viewer on double-click; add 500 MB load guard to TextFileViewer
Mar 11, 2026
Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Copilot
AI
changed the title
Open text-only output nodes in Text Viewer on double-click; add 500 MB load guard to TextFileViewer
TextViewer: replace ScrollView+TextArea with TextFileViewer; add 500 MB load guard
Mar 11, 2026
fabiencastan
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two improvements to text file handling in the UI:
TextFileViewer(the performant ListView-based viewer) now guards against auto-loading files >500 MB — showing a warning overlay with the explicit file size and a confirmation button instead of freezing the UI.TextViewer(the workspace viewer panel) was reimplemented on top ofTextFileViewerinstead of a rawScrollView+TextArea, which had an effective ~50 MB load limit and none of the performance or UX features ofTextFileViewer.Features list
TextFileViewer, including files previously blocked by the ~50 MB limit.TextViewer.qmlnow delegates all file loading and display toTextFileViewer, gaining: line-by-line rendering, built-in reload/scroll/copy toolbar, and the large-file guard above.TextViewer(path display + copy-to-clipboard) is preserved.Implementation remarks
TextFileViewer.qmllargeFileWarning,largeFileSizeMB,largeFileSizeStr(computed once), andconfirmLargeLoadproperties.loadSource()checksFilepath.fileSizeMB(source)before issuing the XHR; if >500 MB and not yet confirmed, it shows the warning and returns early._performLoad(), called after the size check passes or after the user confirms.confirmLargeLoadresets on every source change so each new file gets a fresh check.TextViewer.qmlfileContent,loading,load(),onSourceChanged,ScrollView+TextArea,BusyIndicator, placeholder label, and the redundant "Open Externally" toolbar button (already inTextFileViewer's sidebar).TextFileViewer { source: root.source }.TextVieweris now a thin wrapper that adds only the top file-path context bar.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.