Fix lintDebug: formatted="false" on notification_full_level_content_big (#146)#147
Merged
Merged
Conversation
The string is shown via getString() with no format args, so its literal "%" signs (100%, 20%, 80%) are meant to print verbatim. Lint read them as malformed format specifiers, failing lintDebug on master with 4 StringFormatInvalid errors — a regression from #114. Its two sibling strings from the same #114 PR (how_battery_health_works, battery_reading_unreliable_dialog_message) already carry formatted="false" for the identical "20% and 80%" wording; this one just missed it. Add it in both values/ and values-ar/. CI does not run lintDebug (only tests + assembleDebug + assembleRelease), which is why it slipped through. Closes #146 Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146.
./gradlew lintDebugis currently red on master — 4StringFormatInvaliderrors, a regression from #114.Cause
notification_full_level_content_bigis shown viaNotificationService→getString(...)with no format args, so its literal%signs (100%, 20%, 80%) should print verbatim. Lint reads them as malformed format specifiers.Its two siblings from the same #114 PR —
how_battery_health_worksandbattery_reading_unreliable_dialog_message— already carryformatted="false"for the identical "20% and 80%" wording. This one just missed it.Fix
Add
formatted="false"in bothvalues/strings.xmlandvalues-ar/strings.xml. One attribute, two lines, no wording/behaviour change.Verified
./gradlew lintDebug→ BUILD SUCCESSFUL (was 4 errors)Note (out of scope)
CI runs tests +
assembleDebug+assembleReleasebut notlintDebug, which is why this slipped through. Adding lint to CI is a separate discussion.🤖 Generated with Claude Code