[81] Rested XP and offline rest-state parity

[alseif0x]

Closes #81

Summary

• Ports C++-anchored rested-XP load/save, offline and online accrual, caps, thresholds, tavern/city/faction rest flags, RAF interaction, award consumption, and atomic XP/rest persistence.
• Preserves current health and powers across offline time and validates max-level, no-next-level-XP, scaling-level, group-rate, aura-consumption and malformed-loaded-state boundaries.
• Routes and encodes SMSG_LOG_XP_GAIN like C++, including the active realm in creature GUIDs and semantic comparison that normalizes only the nonzero runtime counter.
• Restores the mutable PlayerScript::OnGiveXP dispatch at the C++ position: initial guards precede it, max-level/RAF/rest processing follow it, and a hook changing XP to zero still reaches RestMgr::GetRestBonusFor(0).
• Adds a guarded end-to-end bot workflow, symmetric C++/Rust rested-XP capture evidence, and reproducible A/B GitHub artifacts for both world-server and wow-test-bot.

Final validation

Final HEAD: 5d5741c16d2b0086a9572f232bc0dd86a984fea1 · Rust 1.88.0 · protoc 28.3

• Local CI-equivalent full suites: wow-data 569, wow-packet 706, wow-map 680, wow-world 2,859; all passed.
• capture-diff: 57 passed, including a clean committed rested-XP golden and collision tests for equal-length semantic regressions.
• Linked world-server/bnet-server checks and builds, format, diff checks, actionlint/wrapper checks, and local Codex review: passed.
• GitHub required checks on this exact HEAD: Format, Check core crates, Focused library tests, MariaDB, and Codex reviewer verdict all green.
• GitHub Codex result: no major issues on reviewed commit 5d5741c16d; all review threads resolved.

Reproducible artifacts

GitHub run 29627836630 built two independent replicas, verified exact checkout provenance, required byte-identical A/B binaries, and published one verified artifact:

• Source commit: 5d5741c16d2b0086a9572f232bc0dd86a984fea1.
• world-server SHA-256: 1bc782c1c4767e0e9aac3e7fb77e9384019da34edaab71fec561af99a44f3425.
• wow-test-bot SHA-256: 87ca9d97e56f30ea2146a290102400bf8b082295477a132ece40e2571c91a1d8.
• Toolchain: rustc 1.88.0 / LLVM 20.1.5.

Only the final 32 MB verified artifact was downloaded locally; the two replica artifacts remained in GitHub.

Final live bot QA

The complete disposable workflow ran against the verified final binaries:

• Offline bonus: wilderness 14.880172; resting 60.000694.
• Kill target: Mana Wyrm entry 15274, persistent spawn 54931, map 530, live counter 38.
• XP packet on realm socket: amount 50, original 100, reason Kill, group bonus 1.0.
• Database: XP 0 -> 100; rest bonus 300 -> 250.
• Full logout/auth/login persistence round-trip verified.
• The target respawn row was observed and then cleared by the natural 300-second runtime timer; it was never deleted by the harness.
• Disposable character/account snapshots and bounded login/save rows were restored.
• Bot report SHA-256: 0c12999fbb155be5957f63636e5813c93f32a6624cb03bd349da3fb79130f1af.
• The normal PR [08.4] [M0.7] Persist direct inventory swaps atomically #104 runtime was restored and reverified on 8085/8086 with executable SHA-256 0bf8b1af06aa7f0468c299ed9339ec0ce09692eb3caac8675a1057ffa21a96bb.

Capture evidence

• Raw C++ capture SHA-256: 977f4634c3a75865922537ec2c8c0d51ccee75631d8cdea3228f70c206552892.
• Raw Rust capture sorted-file-manifest SHA-256: 620285a90d0a36583de80bf9b72409e7960cf398b8deb08972b1bf4b2dff7233 (raw capture remains gitignored).
• The committed fixture contains only the isolated reward packet and an empty accepted-divergence baseline.

Honest boundaries

• The packet fixture proves the rested kill reward wire; offline accrual, DB mutation, relog and natural respawn are proven by the bot workflow.
• The hook seam covers the mutable OnGiveXP contract used by both C++ trees. The configurable xp_boost_PlayerScript content (XP.Boost.Daymask / XP.Boost.Rate) remains a separate unported script/config gap.
• Both C++ references restore is_logout_resting only as an offline-rate selector and do not reconstruct a tavern trigger ID/timer on login. Rust intentionally preserves that parity boundary; changing the shared legacy behavior needs a real tavern-relog capture and a dedicated defect fix.
• The aggregate #PLAYER.12 remains open for full per-Player RestMgr/Player::Update ownership, honor rest, a captured nested RestInfo wire, and remaining runtime integration.
• QA also reconfirmed two separate existing debts outside [follow-up] Rested XP + offline rest-state parity #81: some GameObject/AreaTrigger loaded-grid helpers still hardcode realm 0, and Rust sends SMSG_LOGOUT_COMPLETE on instance instead of the C++ realm socket.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 836b63d2e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[alseif0x]

@codex review\n\nPushed review fixes in 11f09ac. Addressed logout_time=0 accrual, restoring saved logout resting flag, tavern triggers outside the teleport store gate, and rested-XP spend on victim XP grants. The rested XP cap remains next_level_xp * 1.5 / 2 because this matches /home/server/woltk-trinity-legacy/src/server/game/Entities/Player/RestMgr.cpp::SetRestBonus.

[alseif0x]

QA validation checklist:

• Log in with a character that logged out in a rest area; it should still be treated as resting after login and after a logout/relogin cycle.
• Log in with a fresh/no-previous-logout character; it must not start with a huge rested XP pool.
• Kill an XP-granting creature with rested bonus available; the XP gain should include the rested bonus and the rested pool should decrease.
• Grant/earn XP without a creature victim path where possible; it should not spend rested kill XP.
• Verify normal login, movement, combat, logout, and relog still work.

Note: this PR still needs the current-head Codex reviewer verdict before it is merge-ready.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11f09ac8a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[alseif0x]

@codex review

Pushed b77a6cd to address the four actionable comments: rest-state sync now runs after login player setup, tavern area triggers require the authoritative trigger and position validation before setting rest, LogXPGain now sends base XP in original and rested-total XP in amount, and city rest is gated by linked-chat plus non-hostile/sanctuary area flags.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b77a6cd62b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[alseif0x]

Review fixes pushed in f714328.\n\nAddressed current Codex feedback:\n- CMSG_AREA_TRIGGER now validates against AreaTrigger.db2 before tavern/teleport handling; tavern triggers no longer depend on the teleport-only store.\n- Logout-rest restore no longer synthesizes REST_FLAG_IN_TAVERN; it uses a session-local restored bit and clears on authoritative area/zone/tavern updates.\n- Resting flag UpdateObject preserves current canonical player flags and only toggles PLAYER_FLAGS_RESTING.\n- LogXPGain fields restored to C++ order: Original=xp+bonus, Amount=xp.\n- Rest bonus consumption now flushes RestInfo and persists rest state after async XP gain.\n\nValidated locally:\n- PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world area_trigger_tavern --lib\n- PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world load_resting_logout_state_restores_current_rest_flag_like_cpp --lib\n- PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world give_xp_runtime_ --lib\n- PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world update_zone_linked_chat_sets_city_rest_only_when_not_hostile_like_cpp --lib\n- PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world rested_xp --lib\n- cargo fmt --all -- --check\n- git diff --check\n- PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo check -p world-server\n\n@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7143283f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[alseif0x]

@codex review

Pushed e092b0ff for the current review feedback:

• Added represented C++ RestMgr::_restTime and online rested-XP accrual after at least 10s in a rest state (RATE_REST_INGAME represented as 1.0 until config rates are wired).
• Character rest load now clears stale rest flags, inn trigger id, and rest time before optionally restoring characters.is_logout_resting, so a relog/character swap cannot inherit another character's rest mask.
• LinkedChat/capital city rest now follows local C++ Player::UpdateZone: rest if not hostile or if the zone is sanctuary, without requiring faction rest bits.

I did not change leave-packet area-trigger validation: local C++ WorldSession::HandleAreaTriggerOpcode only runs IsInAreaTriggerRadius for packet.Entered, then removes tavern rest on leave. The existing Rust behavior matches that C++ branch.

Validation:

• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world rested_xp --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world update_zone_linked_chat_sets_city_rest_only_when_not_hostile_like_cpp --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world area_trigger_tavern --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world load_rest_state_clears_stale_rest_flags_between_characters_like_cpp --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world give_xp_runtime_ --lib
• cargo fmt --all -- --check
• git diff --check
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo check -p world-server

The rested cap remains next_level_xp * 1.5 / 2 because local C++ RestMgr::SetRestBonus clamps to that formula.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e092b0ff66

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[alseif0x]

Updated in 1d7517c for the current Codex review:

• Persist playerFlags together with the represented rest-state save so character enum can see PLAYER_FLAGS_RESTING after rested logout.
• Revalidate the saved tavern area trigger during the session update and clear REST_FLAG_IN_TAVERN once the player is no longer inside it, matching the local C++ Player::Update tavern recheck.
• Added focused tests for rest-state save flags and stale tavern trigger cleanup.

I intentionally kept these as-is after checking the local C++ source:

• Rested state threshold/cap: local RestMgr::SetRestBonus uses rested at _restBonus >= 1 and caps with nextLevelXP * 1.5f / 2.
• Area-trigger leave radius: local HandleAreaTriggerOpcode applies the radius guard only for packet.Entered.

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d7517cc15

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[alseif0x]

Updated in 86df215 for the latest Codex review:

• Loaded characters.playerFlags during character load, rehydrates the canonical player flags once the login player exists, and the partial rest-state save now preserves loaded DB flags until canonical has received them.
• Loaded rest_bonus now goes through the represented SetRestBonus-style clamp before syncing RestInfo, so stale over-cap and max-level values normalize at login.
• UpdateZone now recalculates represented hostile area state before applying city rest, while keeping local C++ AreaFlags::LinkedChat as the capital-city gate.

Validation: cargo test -p wow-world player_flags --lib, cargo test -p wow-world rest --lib, cargo fmt --check, git diff --check.

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 86df215bc6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[alseif0x]

Updated in 18962c3a for the latest Codex feedback:

• Self-create packets now carry loaded/canonical PlayerFlags and PlayerFlagsEx, including RESTING/GHOST/AFK/DND-style persisted bits.
• Online rested-XP spend now persists only restState, playerFlags, and rest_bonus; it no longer stamps logout_time or is_logout_resting.
• Far teleport world-port ack now resolves destination zone/area and recomputes represented rest flags before the destination self-create packet.
• RAF-linked rest state is preserved when loading/normalizing rested bonus.

Validation after rebasing onto current 3.4.3:

• cargo fmt --check
• git diff --check
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world player_create_flags_use_loaded_and_canonical_bits_like_cpp --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world online_rest_state_save_statement_does_not_touch_logout_columns_like_cpp --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world load_raf_linked_rest_state_survives_rest_bonus_set_like_cpp --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world world_port_response_recomputes_destination_rest_state_before_self_create_like_cpp --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-packet player_create_writes_loaded_player_flags_like_cpp --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-database character_save_statements_match_cpp_sql_exactly --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo check -p world-server

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18962c3af4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[alseif0x]

Addressed the latest Codex review follow-ups in 40870ed:

• wired CONFIG_MAX_PLAYER_LEVEL and Rate.Rest.* into WorldSession rested-XP config
• normalized RAF rest state from current RAF eligibility instead of preserving stale DB state
• applied SPELL_AURA_MOD_RESTED_XP_CONSUMPTION to rested pool loss while preserving awarded bonus XP
• guarded tavern area-trigger leave packets when the player is still inside the DB2 trigger radius

Validation:

• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world rested_xp --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world area_trigger_tavern --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world stale_raf_linked_rest_state_recomputes_when_bonus_is_normalized_like_cpp --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-data spell_effect_constants_match_cpp_shared_defines --lib
• PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo check -p world-server
• cargo fmt --check
• git diff --check

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 40870ed051

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[alseif0x]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 5ec8a50c8a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[alseif0x]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4464f75cd1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[alseif0x]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d77be5347

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[alseif0x]

@codex review

Final review target: 5d5741c16d2b0086a9572f232bc0dd86a984fea1.

The final review series hardens executable/capture provenance, makes semantic accepted-baseline signatures collision-safe, pins the physical AreaTable FactionGroupMask mapping, normalizes zero-integer rested awards like RestMgr::GetRestBonusFor, and restores the mutable PlayerScript::OnGiveXP dispatch at the exact C++ position (including hook-to-zero and pre-max-level behavior). All six outstanding threads were answered against both C++ references and resolved.

Local current-HEAD gate: full CI-equivalent checks passed; wow-world 2859/2859; capture-diff 57/57 including clean rested-XP golden; local Codex review clean.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 5d5741c16d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".