PSO fixes - #452
Open
uyraq2001 wants to merge 26 commits into
Open
Conversation
uyraq2001
force-pushed
the
master
branch
6 times, most recently
from
June 12, 2026 01:37
6bad810 to
1a30390
Compare
uyraq2001
marked this pull request as ready for review
June 12, 2026 01:38
| }); | ||
| } | ||
|
|
||
| void PasswordSettingsImpl::fetch(const QModelIndex &index) { |
Contributor
There was a problem hiding this comment.
I'd put a Doxygen comment before methods, to document what the method does, what it accepts as parameters, what it asserts (if it does so) and what it returns. Also, if there are any exceptions that can be thrown in the method, I'd document them too.
Samael-fhts
reviewed
Jun 17, 2026
Samael-fhts
reviewed
Jun 17, 2026
| else if (object.is_class(CLASS_SUBNET)) { | ||
| stacked_widget->setCurrentWidget(subnet_results_widget); | ||
| subnet_results_widget->update(object); | ||
| } |
Collaborator
There was a problem hiding this comment.
Did u move that commit to another PR?
Contributor
|
Hi! I think it would be better if we would provide at least some overview of the work we've done in the PR description, aside from the PR title. Here we have 11 commits and no information provided. That means a reviewer will have hard time figuring out what the author of those changes wanted to accomplish by this work. |
uyraq2001
force-pushed
the
master
branch
9 times, most recently
from
June 30, 2026 18:12
51f9de0 to
b5249a3
Compare
Collaborator
|
I have found 2 bugs now:
|
uyraq2001
force-pushed
the
master
branch
2 times, most recently
from
July 13, 2026 21:33
47a136b to
8d0dfd5
Compare
added 22 commits
July 31, 2026 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.