Skip to content

LEX bug test#1186

Open
orimay wants to merge 1 commit intoamark:masterfrom
orimay:patch-1
Open

LEX bug test#1186
orimay wants to merge 1 commit intoamark:masterfrom
orimay:patch-1

Conversation

@orimay
Copy link
Copy Markdown
Contributor

@orimay orimay commented Jan 12, 2022

Say, we have a list of props on a node:

aa
ab
ac

Then we query it like this:

{
  '.': {
    '*': 'a',
    '>': 'ab'
  }
}

The result we expect:

ab
ac

The result we get:

aa
ab
ac

Say, we have a list of props on a node:
aa
ab
ac

Then we query it like this: 
{
  '.': {
    '*': 'a',
    '>': 'ab'
  }
}

The result we expect:
ab
ac

The result we get:
aa
ab
ac
@amark
Copy link
Copy Markdown
Owner

amark commented Feb 4, 2022

👍 sounds like this is gonna be a win+win for everything, your other PR had smaller code, and this is a more sensible default that didn't add any complexity. I'm very impressed! Thanks for being willing to switch to ECMAscript5.

@bmatusiak
Copy link
Copy Markdown
Collaborator

@orimay we moved String.match() to lib/lex.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants