Skip to content

fix: Delegate branch calculation to correct simulator#369

Merged
speller26 merged 1 commit into
mainfrom
delegate
May 1, 2026
Merged

fix: Delegate branch calculation to correct simulator#369
speller26 merged 1 commit into
mainfrom
delegate

Conversation

@speller26
Copy link
Copy Markdown
Member

@speller26 speller26 commented May 1, 2026

Issue #, if available:

Description of changes:

RIght now, branch simulations are always done with StateVectorSimulation; we change this behavior to use the correct simulator implementation. With this, users will be able to plug in any backend to run dynamic circuits by subclassing BaseLocalSimulator and Simulation.

Testing done:

Added extra test for error on branch simulation with no provided simulator

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@speller26 speller26 requested a review from a team as a code owner May 1, 2026 02:45
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (78b059e) to head (b60cd0a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #369   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         4884      4884           
  Branches       561       562    +1     
=========================================
  Hits          4884      4884           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AbeCoull
Copy link
Copy Markdown
Contributor

AbeCoull commented May 1, 2026

This is a nice change!

@speller26 speller26 merged commit 1d8fcea into main May 1, 2026
30 checks passed
@speller26 speller26 deleted the delegate branch May 1, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants