fix: shallow-copy circuit instructions into initial branched path#371
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 4884 4885 +1
Branches 562 562
=========================================
+ Hits 4884 4885 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yitchen-tim
approved these changes
May 1, 2026
speller26
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #370
Description of changes:
The initial branched
SimulationPathwas seeded with shared references toCircuit.instructions, so the contiguous-qubit remapping inBaseLocalSimulator._map_circuit_qubitssilently retargeted the path's gates and corrupted the final state whenever the circuit's qubit set was non-contiguous. Shallow-copying each instruction into the initial path keeps the two lists independent.Testing done:
Added two regression tests in
TestMCMNonContiguousClassicalIndicescovering the minimal repro and the non-monotonicc[N]case; both fail onmainand pass with the fix. All tests pass.Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.