sync: merge from main#1127
Closed
virajvchaudhari wants to merge 347 commits into
Closed
Conversation
* add duration type to FreeParameterExpression * consider FreeParameter as float * move to_ast to FreeParameterExprsesion * change back FPEIdentifier's parent to Identifier * clean up syntax * add precision about the expression type * add __repr__ to waveforms * do not simplify constants with defcals * add type validation * update oqpy to 0.3.2 * fix linters * increase test coverage * update to oqpy 0.3.3 * fix last merge commit * fix type hints * update to oqpy 0.3.4 * fix oqpy to 0.3.3 * remove FreeParameterExpressionIdentitifer * declare input parameters with pulse sequences * use machine-size types * create _InputVarSplitter * remove never visited branch * fix partial coverage * hacking test because the set order changes with python version * pass inputs with PulseSequence * pass empty dict to OpenQasmProgram * force FloatVar locally * add FreeDurationParameterExpression * simplify operation methods * use TYPE_CHECKING * move FreeDurationParameterExpression to pulse folder * remove TYPE_CHECKING * remove algebra rule for FreeDurationParameterExpression * accept integers as binding values * convert FreeParameter to OQpyExpression * fix coverage * clean tests * register freeparameters with delay * trigger GitHub actions * modify and rename _format_parameter_ast * update to oqpy 0.3.5 OQPy 0.3.5 converts now correctly ExpressionConvertible to duration * trigger GitHub actions * clean code * clean import * pass empty dict early * pass gate_definitions sets to batches * clean code * changes according to feedback * fix mock tests * avoid infinite loop * scale code * rename vars * fix merge * improve linters * Merge branch 'main' into jcjaskula-aws/gate_definitions_batch * fix merge * rename var * fix docstring * fix docstring --------- Co-authored-by: Cody Wang <speller26@gmail.com> Co-authored-by: Abe Coull <85974725+math411@users.noreply.github.com> Co-authored-by: Kshitij Chhabra <kshitijc@users.noreply.github.com> Co-authored-by: Aaron Berdy <berdy@amazon.com>
* Update dependent-tests.yml --------- Co-authored-by: Abe Coull <accoull@amazon.com>
* add support for openqasm measure on a subset of qubits * add tests to increase test coverage * Update circuit diagram to new format * Increase test converage * add tests for edge cases * infra: bump default simulator dependency to 1.21.0 * add integ tests * remove unecessary check on the target list * add tests for result type and verbatim edge cases * Update error messages, add diagram tests, and update measure to measure all qubits when no targets provided * fix linter type hint error in docstring * add measure support to braket_program_context and added tests for from_ir * fix type hint documentation error * Fix linter errors * Apply suggestions from code review Co-authored-by: Ryan Shaffer <3620100+rmshaffer@users.noreply.github.com> * add error if qubit already measured, update target_qubits to QubitSetInput * fix linter error * remove qubit_count and ascii_symbols from Measure * Apply suggestions from code review Co-authored-by: Ryan Shaffer <3620100+rmshaffer@users.noreply.github.com> * remove error if measure targets are outside circuit * update error message casing to be consistent, change ascii_symbol type, and combined error message for qubits already measured * add a test for measuring qubits not on the circuit * allow operations after a measure if the target is not measured * remove hanging prints * fix missed case inconsistency * fix missed case inconsistency * add comments for the different cases if a qubit is already measured * updated test to check for edge case --------- Co-authored-by: Ryan Shaffer <3620100+rmshaffer@users.noreply.github.com>
* fix: prevent repeated measurements on a qubit * break repeated qubits into two error messages for repeat in measured_targets or repeat in target_qubits
* Improve gphase unitary matrix definition in docstring * Remove extra whitespace --------- Co-authored-by: Abe Coull <85974725+math411@users.noreply.github.com>
Co-authored-by: Ryan Shaffer <3620100+rmshaffer@users.noreply.github.com>
…ss for updated `Circuit.from_ir` (#1085) Co-authored-by: Ryan Shaffer <3620100+rmshaffer@users.noreply.github.com> Co-authored-by: Cody Wang <speller26@gmail.com>
Co-authored-by: Nagji <ltnln@amazon.com> Co-authored-by: Cody Wang <speller26@gmail.com> Co-authored-by: Ryan Shaffer <3620100+rmshaffer@users.noreply.github.com> Co-authored-by: maolinml <86260930+maolinml@users.noreply.github.com>
Co-authored-by: Ryan Shaffer <3620100+rmshaffer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.