docs: audit and correct attributes.md against actual assessor code

[jwm4]

Summary

Full accuracy audit of docs/attributes.md found widespread drift between the documentation and the actual assessor implementations. This PR corrects everything found.

Weight corrections

Pre-v2.0.0 weights that were never updated in the doc:

Attribute	Doc said	Actual
readme_structure	10%	5%
type_annotations	10%	8%
standard_layout	10%	5%
lock_files	10%	5%
cyclomatic_complexity	3%	2%
structured_logging	3%	2%
issue_pr_templates	Tier 4 / 1%	Tier 3 / 1.5%

Criteria corrections

The doc described checks the assessors do not actually perform:

• claude_md_file: doc claimed 6 required content sections; code only checks the file exists at ≥50 bytes. Added AGENTS.md as a fully equivalent alternative (scores 100).
• readme_structure: doc listed 8 required sections; code checks 3 (installation, usage, development), pass ≥75.
• test_execution: doc described 70/80/90% coverage thresholds; assessor does not measure coverage at all — it checks whether test config files are present.
• lock_files: added freshness check (15pt deduction if >6 months old) and requirements.txt pin quality validation; removed gitignore claim that is not checked.
• deterministic_enforcement: doc required CI enforcement; assessor only checks .pre-commit-config.yaml (60pts), .claude/settings.json hooks (30pts), .husky (10pts). Pass on pre-commit config alone.
• gitignore_completeness: replaced category-based description with actual pattern-based mechanism (70% of language-specific patterns from hardcoded list).
• container_setup: added Containerfile as alternative, .dockerignore scoring, and conditionality (not_applicable if no container file found).

New content

Full write-ups added for three Tier 1 attributes that previously had only one-liners:

• ci_quality_gates (5%)
• single_file_verification (5%)
• dependency_security (5%)

New full entry for repomix_config (Tier 3, 2%) — recently registered assessor, not yet documented.

Other fixes

• separation_concerns → separation_of_concerns (attribute ID was wrong throughout)
• Tier 3 attribute count: 5 → 6
• Implementation status table updated: all tiers are fully implemented; removed stale "active development / planned" labels

Assessor code fixes

default_weight values in four assessors were out of sync with the yaml (yaml is authoritative):

File	Field	Was	Now
stub_assessors.py	DependencyPinningAssessor	0.10	0.05
security.py	DependencySecurityAssessor	0.04	0.05
code_quality.py	CyclomaticComplexityAssessor	0.03	0.02
code_quality.py	StructuredLoggingAssessor	0.015	0.02

Test plan

• 1152 passed, 21 skipped — no regressions
• black . && isort . && ruff check . — clean

🤖 Generated with Claude Code under the supervision of Bill Murdock

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: ccb37d3d-dd5e-494c-9d05-0578bb15b4c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)

Validation error: String must contain at most 250 character(s) at "tone_instructions"

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch docs/attributes-accuracy-audit

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

📈 Test Coverage Report

Branch	Coverage
This PR	72.5%
Main	72.5%
Diff	✅ +0%

---

Coverage calculated from unit tests only