Skip to content

fix: decouple repo/workflow cloning from S3 availability#1532

Open
guzalv wants to merge 1 commit intoambient-code:mainfrom
guzalv:fix/hydrate-s3-decoupling
Open

fix: decouple repo/workflow cloning from S3 availability#1532
guzalv wants to merge 1 commit intoambient-code:mainfrom
guzalv:fix/hydrate-s3-decoupling

Conversation

@guzalv
Copy link
Copy Markdown

@guzalv guzalv commented May 8, 2026

Summary

  • The init container (hydrate.sh) exited early (exit 0) when S3 credentials were missing, which killed the entire script before reaching repository and workflow cloning logic further down.
  • This meant custom workflows could not be loaded unless S3/MinIO was fully configured, even though workflow cloning has no dependency on S3.
  • Replaces the early exit with a conditional block that wraps only the S3 hydration operations, allowing repo cloning, workflow cloning, and git state restore to proceed independently.
  • Also guards the S3 repo-state restore section with an S3_PATH check so it only runs when S3 was successfully configured.

Changed files

File Change
components/runners/state-sync/hydrate.sh Replace exit 0 with if/else conditional around S3 operations; guard repo-state restore with S3_PATH check

Test plan

  • Start a session without S3/MinIO configured — repos and workflows should still clone successfully
  • Start a session with S3 configured — state hydration and repo-state restore should work as before
  • Verify init container logs show "S3 not configured - skipping state hydration" when S3 is unavailable
  • Verify init container does not attempt rclone commands when S3 credentials are missing

The init container exited early (exit 0) when S3 credentials were
missing, which prevented all downstream operations including
repository and workflow cloning. This meant custom workflows could
not be loaded unless S3/MinIO was configured.

Replace the early exit with a conditional block that wraps only the
S3 hydration logic, allowing repo/workflow cloning and git state
restore to proceed independently of S3 availability.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

Warning

Rate limit exceeded

@guzalv has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 49 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: efc2207f-f748-4d54-9f0a-407780057477

📥 Commits

Reviewing files that changed from the base of the PR and between 070520c and 5eb9bee.

📒 Files selected for processing (1)
  • components/runners/state-sync/hydrate.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 8, 2026

Deploy Preview for cheerful-kitten-f556a0 ready!

Name Link
🔨 Latest commit 5eb9bee
🔍 Latest deploy log https://app.netlify.com/projects/cheerful-kitten-f556a0/deploys/69fd9cdafd69480008d338b1
😎 Deploy Preview https://deploy-preview-1532--cheerful-kitten-f556a0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant