Added .spi.yml#12
Merged
Merged
Conversation
📝 WalkthroughWalkthroughAdds a new ChangesSPI configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.spi.yml:
- Around line 4-6: The current SPI manifest only adds a linux builder config and
does not actually prevent Apple-platform indexing. Update the manifest and/or
Package.swift so the package’s supported platforms are explicitly Linux-only if
that is the intent, or remove the Linux-only claim if other platforms are still
supported. Use the builder.configs entry and the package platform declarations
together, and verify the result with the SPI Manifest Validator.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11
I added a .spi.yml linking the KeyringAccess documentation and specifying only Linux compatibility.
If someone needs the SecretService docs, they will have to use the link from the readme
Added a new
.spi.ymlto improve Swift Package Index indexing.external_linksentry for KeyringAccessNice touch: this makes the package’s platform support explicit while also pointing users to the right documentation.