Skip to content

Added .spi.yml#12

Merged
MiaKoring merged 2 commits into
amethystsoft:mainfrom
MiaKoring:main
Jun 26, 2026
Merged

Added .spi.yml#12
MiaKoring merged 2 commits into
amethystsoft:mainfrom
MiaKoring:main

Conversation

@MiaKoring

@MiaKoring MiaKoring commented Jun 26, 2026

Copy link
Copy Markdown
Member

Resolves #11

I added a .spi.yml linking the KeyringAccess documentation and specifying only Linux compatibility.

If someone needs the SecretService docs, they will have to use the link from the readme

Added a new .spi.yml to improve Swift Package Index indexing.

  • Links the package documentation via an external_links entry for KeyringAccess
  • Restricts the package builder configuration to Linux only
  • Keeps the SPI metadata minimal and aligned with the intended package support

Nice touch: this makes the package’s platform support explicit while also pointing users to the right documentation.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a new .spi.yml file with SPI version metadata, a documentation link, and linux build configuration.

Changes

SPI configuration

Layer / File(s) Summary
SPI metadata and build config
.spi.yml
version: 1, external_links.documentation, and builder.configs are defined in the new SPI config file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately describes the main change: adding a .spi.yml file.
Linked Issues check ✅ Passed The new .spi.yml matches issue #11 by adding Swift Package Index configuration for indexing support.
Out of Scope Changes check ✅ Passed The changes stay focused on the SPI config file and do not introduce unrelated scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.spi.yml:
- Around line 4-6: The current SPI manifest only adds a linux builder config and
does not actually prevent Apple-platform indexing. Update the manifest and/or
Package.swift so the package’s supported platforms are explicitly Linux-only if
that is the intent, or remove the Linux-only claim if other platforms are still
supported. Use the builder.configs entry and the package platform declarations
together, and verify the result with the SPI Manifest Validator.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 517ad5ab-2a48-402a-ad75-1da8b46e9c6c

📥 Commits

Reviewing files that changed from the base of the PR and between c91976c and b642746.

📒 Files selected for processing (1)
  • .spi.yml

Comment thread .spi.yml
@MiaKoring
MiaKoring merged commit cf20cf5 into amethystsoft:main Jun 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add .spi.yml

1 participant