fix: make contract delivery retry-safe#67
Merged
andreogle merged 3 commits intoJul 11, 2026
Conversation
Bubble callback failures so valid signed payloads cannot be consumed by premature or underfunded submissions. Harden freshness, dependency validation, and FHE trust semantics, and add a strict-majority quorum consumer example with adversarial tests.
Independent review found that exact timestamp and payload matching is not viable with separately timed Airnode responses. Remove the copy-paste trap and align verifier documentation with retry-safe callback semantics.
Replace an accidentally committed truncation marker with the complete retry-safety explanation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fromExternalsemantics and removes nonexistent revocation behaviorAudit findings fixed
High
Medium
ConfidentialPriceFeedaccepted future timestamps, allowing a trusted signer or clock error to poison an endpoint against later valid updates.ConfidentialPriceFeedhad no maximum-age check and could accept arbitrarily old first observations.deny/revocation operation that the current FHE ACL does not provide.attestedAt + maxStalenesscheck could overflow when configured with an unbounded maximum.Review-discovered product risk
Example decision
No new example ships in this PR. The candidate quorum example was removed rather than publishing a copy-paste pattern that the current signing pipeline cannot support reliably.
Verification
forge test: 49 tests pass, including 6 invariant properties at 16,384 calls each and 1,000 fuzz runs for arbitraryint256pricesforge coverage: 100% line and statement coverage forAirnodeVerifier,AirnodePriceConsumer, andConfidentialPriceFeedCompatibility note
Callback failure semantics change intentionally. A callback revert now reverts the verifier transaction and preserves a retry path instead of marking the delivery successful.
Remaining boundaries
ConfidentialPriceFeedis an adapter-based example, not a production FHE integration. It trusts the configured adapter to validate ciphertext proofs and binding.