Add flexbox sample#45
Open
JonEckenrode wants to merge 19 commits intomainfrom
Open
Conversation
…id/adaptive-apps-samples into adaptive-apps-samples-readme-reorg
…id/adaptive-apps-samples into adaptive-apps-samples-readme-reorg
…id/adaptive-apps-samples into adaptive-apps-samples-readme-reorg
…id/adaptive-apps-samples into adaptive-apps-samples-readme-reorg
…id/adaptive-apps-samples into adaptive-apps-samples-readme-reorg
…id/adaptive-apps-samples into adaptive-apps-samples-readme-reorg
…id/adaptive-apps-samples into adaptive-apps-samples-readme-reorg
…id/adaptive-apps-samples into adaptive-apps-samples-readme-reorg
…id/adaptive-apps-samples into adaptive-apps-samples-readme-reorg
JonEckenrode
requested review from
chikoski,
cka-dev and
juliantoledo
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new Jetpack Compose sample application demonstrating the FlexBox API through various layout examples, including navigation and basic architectural components. Feedback focuses on improving consistency and code quality, such as utilizing the version catalog for dependencies, adopting data object for state-less sealed interface implementations, and removing unused imports or integrating the currently unused ViewModel. Additionally, suggestions were made to replace hardcoded colors with theme-aware values and to adjust the modifier order to ensure correct safe area padding behavior.
…data object, and integrate ViewModel
…ring, and use theme-aware color scheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlexBox sample for the adaptive apps development hub sample page.